Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #250

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Fix typos #250

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4f156f
Fix typos
szepeviktor Jul 12, 2024
d0e06f6
add deprecated function
szepeviktor Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [0.4.1](https://github.com/10up/wp_mock/compare/0.4.1...0.4.0) - 2019-02-26
### Added
- **PHPUnit 8 Compatiblity**
- **PHPUnit 8 Compatibility**
- This release brings us up to date with the latest release of PHPUnit.
- Please note: As with the previously-tagged release, this is not necessarily a stable release!

## [0.4.0](https://github.com/10up/wp_mock/compare/0.4.0...0.3.0) - 2019-01-16
### Added
- **PHPUnit 7 Compatiblity**
- **PHPUnit 7 Compatibility**
- This release brings us up to date both with PHPUnit and with PHP itself. The minimum version of PHP now supported by the project is *7.1*.
- *Please note:* As with the previously-tagged release, this is not necessarily a stable release!

Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Contributions are **welcome** and will be fully **credited**.

We accept contributions via Pull Requests on [Github](https://github.com/10up/wp_mock)
We accept contributions via Pull Requests on [GitHub](https://github.com/10up/wp_mock)

## Branches

Expand Down
2 changes: 1 addition & 1 deletion docs/general/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ The bootstrap file can do a few things:

## Configure PHPUnit with WP_Mock

You can run PHPUnit using a `--bootstrap` flag to include your boostrap configuration while executing your tests (see [PHPUnit documentation](https://docs.phpunit.de/en/9.5/textui.html?highlight=--bootstrap#command-line-options)):
You can run PHPUnit using a `--bootstrap` flag to include your bootstrap configuration while executing your tests (see [PHPUnit documentation](https://docs.phpunit.de/en/9.5/textui.html?highlight=--bootstrap#command-line-options)):

```shell
./vendor/bin/phpunit --bootstrap /path/to/bootstrap.php
Expand Down
2 changes: 1 addition & 1 deletion features/bootstrap/FunctionsContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public function iExpectWhenIRunWithArgs( $return, $function, TableNode $args ) {
/**
* @Then I expect :return when I run :function
*/
public function iExcpectWhenIRun( $return, $function ) {
public function iExpectWhenIRun( $return, $function ) {
Copy link
Contributor

@nmolham-godaddy nmolham-godaddy Jul 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you fully check the implications of renaming this method? I know it is a typo, but it is considered code change, what do you think about defining a new alias method to it, and marking this one as deprecated? ex:

/**
 * @Then I expect :return when I run :function
 *
 * @deprected use static::iExpectWhenIRun instead
 */
public function iExcpectWhenIRun( $return, $function ) {
    static::iExpectWhenIRun( $return, $function )
}

/**
 * @Then I expect :return when I run :function
 */
public function iExpectWhenIRun( $return, $function ) {
    $this->iExpectWhenIRunWithArgs( $return, $function, new TableNode( array( array() ) ) );
}

Copy link
Contributor Author

@szepeviktor szepeviktor Jul 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
TBH I treat everything as text when I fix typos.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, it happens, thanks for the fixes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to contribute.

$this->iExpectWhenIRunWithArgs( $return, $function, new TableNode( array( array() ) ) );
}

Expand Down
Loading