Remove the option for disabling NREUM on AMP pages #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no context where you would want to include New Relic scripts in AMP pages, so it doesn't make sense to expose this as an option. This removes the option, and just hooks `disable_nr_autorum()` onto the `pre_amp_render_post` action, so that any pages which are served through the AMP plugin will not include the browser monitoring instrument script.
|
Fixes #7. Doesn't address the case noted in #10 (comment), but that can't be addressed in this plugin since the plugin isn't loaded at the time that batcache intervenes. |
|
@nicholasio Can you review/merge this for me? It just removes a meaningless option from the plugin's settings fields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no context where you would want to include New Relic scripts in
AMP pages, so it doesn't make sense to expose this as an option. This
removes the option, and just hooks
disable_nr_autorum()onto thepre_amp_render_postaction, so that any pages which are served throughthe AMP plugin will not include the browser monitoring instrument
script.