Add a filter around the return value from our current_user_can_upload_svg
method
#193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds a new filter,
safe_svg_current_user_can_upload
, around the returned value from ourcurrent_user_can_upload_svg
method. This filter allows others to have more fine-tune control on who can or cannot upload svgs. For instance, this would allow you to lock down uploads to specific users, instead of specific roles. Or would allow you to allow non-logged in users the ability to upload svgs.Closes #192
How to test the Change
current_user_can_upload_svg
and modify permissions, running through the tests again to ensure things work. As an example, could addadd_filter( 'safe_svg_current_user_can_upload', '__return_false' );
and ensure that no one can upload svgs, oradd_filter( 'safe_svg_current_user_can_upload', '__return_true' );
and ensure everyone can upload svgs.Changelog Entry
Credits
Props @dkotter
Checklist: