In the admin, only render the WebAmp player if the preview state is toggled #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2021 10:49
…ake sure we remove the player if we toggle back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Current approach is to render the WebAmp player as soon as at least one audio file has been added. This approach is fine but the player is causing some performance and styling issues. This PR adds a new preview toggle and we only render the player when in that preview state.
Couple things to note:
Designs
Alternate Designs
Stick to rendering the player anytime we have at least one audio file; or some other render approach
Benefits
Performance isn't impacted as much and you can toggle off of the preview so the rest of the page is still usable
Possible Drawbacks
Not as UX friendly
Applicable Issues
#9