-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/154 PHP Version Check #165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmarshall511 Thank you for the PR, LGTM. I tested it and saw the notice when the PHP version is below the minimum required. However, outlined a few minor tweaks below.
Thanks for taking a look @faisal-alvi! Updates made, ready for your review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmarshall511 The cypress tests are failing, I re ran the failed tests but they are still failing. I can see they passed in your first commit, but failed in the latest, can you please check it?
https://github.com/10up/publisher-media-kit/actions/runs/6352469169/job/17304966900#step:9:164
Note: The failed cypress tests are supposed to be fixed in #166 Let's wait until that is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeffpaul can you please help to merge this one? |
Description of the Change
Added a minimum PHP version check for 7.4.
Closes #154
How to test the Change
Changelog Entry
Credits
Props @bmarshall511
Checklist: