Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/570: Enhancements to menu item classes #818

Merged
merged 5 commits into from
Aug 27, 2024
Merged

feat/570: Enhancements to menu item classes #818

merged 5 commits into from
Aug 27, 2024

Conversation

Sidsector9
Copy link
Member

Description of the Change

Closes #570

Adds the following:

  • Support for custom menu item HTML classes.
  • menu-item-has-children HTML class for menu item with children.

How to test the Change

  1. Perform the basic setup.
  2. Add children to a menu item.
  3. Add a custom CSS class to a menu item.
  4. Verify on the frontend.

Changelog Entry

Added - Support for custom menu item CSS classes.
Added - menu-item-has-children CSS class for menu item with children.

Credits

Props @burhandodhy @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link

vercel bot commented Jul 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headstarwp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 7:04pm

Copy link

changeset-bot bot commented Jul 20, 2024

🦋 Changeset detected

Latest commit: b50807d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@headstartwp/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Sidsector9 Sidsector9 self-assigned this Jul 20, 2024
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headstartwp

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 124.05 KB (🟡 +35 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headstartwp

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 124.06 KB (🟡 +39 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@nicholasio nicholasio merged commit fc7e426 into develop Aug 27, 2024
13 checks passed
@nicholasio nicholasio deleted the feat/570 branch August 27, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional classes on Menu
2 participants