New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WP Plugin - Rector - automatic and manual fixes #695

Closed

claytoncollie wants to merge 40 commits into develop from feature/wp-rector

Contributor

claytoncollie commented Feb 15, 2024 •

edited

Loading

Description of the Change

This PR adds Rector to the wp plugin and a GitHub action to enforce the coding standards in the future.

Requires #696

Part 4 for addressing #625

Changelog Entry

Changed - PHP coding standards and docblocks using Rector

Credits

Props @claytoncollie

claytoncollie added 23 commits

January 29, 2024 10:48


          Start tracking the composer lock file to make sure we are installing …

14acdad

…the exact versions


          Update the 10up phpcs package to 3.0.0 and add some extra commands

825dc52


          Adjust phpcs config to scan files properly

48a93f6


          Automatic linting with phpcbf

4ae5d43


          Remove exception from phpcs config

10a669a


          Rename parameter array to be rules

f468cd8


          Use wp _safe_redirect instead of wp_redirect

7fa403a


          Ignore last parameter is not being used

11a4c2e


          remove unused parameter

75ef028


          Ignore tax query being slow

ea3aa5b


          Ignore nonce verification warning


          Use strict comparison for in array

93495f5


          Use wp _safe_redirect instead of wp_redirect

ed82abf


          Translate string and escape output

aee5aa9


          Remove unused parameter and docblock

378ab91


          Remove unused parameter and docblock

fe5cb6b


          Remove unused parameter and docblock

5842bb1


          Change the admin notice to break item down into smaller pieces

5ada585


          change parameter to not be a reserved keyword

1f8a7ab


          Require Rector. Provide config. Add action to enforce standard.

e4bf192


          Fix constant reference in config

34c6284


          FOrce short array syntax

faf1d18


          Enforce Rector coding standards. Add parameter and return type hintin…

43aa5a2

…g. Refactor docblocks.

changeset-bot bot commented Feb 15, 2024 •

edited

Loading

🦋 Changeset detected

Latest commit: 0d7a66d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@headstartwp/headstartwp	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel bot commented Feb 15, 2024 •

edited

Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
headstarwp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 8, 2024 0:20am

claytoncollie added 2 commits

February 15, 2024 15:00


          Ignore certain files and enforce short array syntax

f155711


          Enforce short array syntax

92ab1b9

Contributor

github-actions bot commented Feb 15, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌


          Merge feature/wp-plugin-short-array-syntax into feature/wp-rector

2843df0

vercel bot deployed to Preview – headstarwp

February 15, 2024 21:05

View deployment

claytoncollie added 3 commits

April 3, 2024 09:32


          Merge develop into feature/wp-rector

9aa10df


          Linting

39e73fd


          Merge develop into feature/wp-rector

44904d6

vercel bot deployed to Preview – headstarwp

April 3, 2024 14:54

View deployment

Contributor

github-actions bot commented Apr 3, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌


          REturn types

a78b08b

vercel bot deployed to Preview – headstarwp

April 3, 2024 15:05

View deployment

Contributor

github-actions bot commented Apr 3, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌


          Preview Test

b6653c3

vercel bot deployed to Preview – headstarwp

April 3, 2024 15:15

View deployment

Contributor

github-actions bot commented Apr 3, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Contributor Author

claytoncollie commented Apr 3, 2024

@nicholasio I merged develop into this branch and re-ran the linting and refactor scripts. The phpunit tests are still failing for some reason but this might be good to recheck the Preview functionality when you get a chance.

nicholasio added 2 commits

May 8, 2024 08:24


          Merge branch 'develop' into feature/wp-rector

1e2e1e1


          fix: tests

634824b

vercel bot deployed to Preview – headstarwp

May 8, 2024 11:46

View deployment


          chore: changeset

da086af

vercel bot deployed to Preview – headstarwp

May 8, 2024 11:47

View deployment

Contributor

github-actions bot commented May 8, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

1 similar comment

Contributor

github-actions bot commented May 8, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌


          fix: making rector happy

0b5fa9e

vercel bot deployed to Preview – headstarwp

May 8, 2024 11:54

View deployment

Contributor

github-actions bot commented May 8, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌


          chore: make phpcs happy

cfc32bd

vercel bot deployed to Preview – headstarwp

May 8, 2024 11:57

View deployment

Contributor

github-actions bot commented May 8, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌


          fix: restore deleted code

0d7a66d

vercel bot deployed to Preview – headstarwp

May 8, 2024 12:20

View deployment

Contributor

github-actions bot commented May 8, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Member

nicholasio commented May 8, 2024 •

edited

Loading

This is causing multiple errors. Rector is definately making breaking changes. I appreciate all the work here but I believe this is too risky to merge at this point. It would require a full QA round to ensure everything is working as expected as our php tests do not cover everything.

I'm going to close this for now, perhaps we can revisit it once we have better tests coverage for the plugin and the e2e tests set up.

nicholasio closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet