New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: opt into html tag processor if available #525

Merged

nicholasio merged 11 commits into develop from feature/html-tag-processor

Jun 18, 2023

Member

nicholasio commented Jun 17, 2023 •

edited

Loading

Description of the Change

This PR adds the ability to use the new WP_HTML_Tag_Processor API instead of DomDocument. DomDocument is still the default API but if WP_HTML_Tag_Processor is available and the user has opted in via the tenup_headless_wp_render_block_use_tag_processor filter, the new API will be used to enhance block markup with block data.

How to test the Change

Checklist:

I agree to follow this project's Code of Conduct.
I have updated the documentation accordingly.
I have added tests to cover my change.
All new and existing tests pass.

github-actions bot added 3 commits

June 16, 2023 10:50


          fix: do not parse classic blocks

1f9f138


          test: wip

3c18421


          feat: leverage html tag processor if available

468685c

changeset-bot bot commented Jun 17, 2023 •

edited

Loading

🦋 Changeset detected

Latest commit: 65717a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@headstartwp/headstartwp	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel bot commented Jun 17, 2023 •

edited

Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
headstarwp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 18, 2023 4:15pm

vercel bot deployed to Preview – headstarwp

June 17, 2023 01:17

View deployment

Contributor

github-actions bot commented Jun 17, 2023

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌


          Merge branch 'feature/php-tests' into feature/html-tag-processor

a8504b1

vercel bot deployed to Preview – headstarwp

June 17, 2023 13:47

View deployment

Contributor

github-actions bot commented Jun 17, 2023

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌


          feat: setting up tests

894182f

vercel bot deployed to Preview – headstarwp

June 17, 2023 17:12

View deployment


          chore: fix action

f23f711

vercel bot deployed to Preview – headstarwp

June 17, 2023 17:14

View deployment

Contributor

github-actions bot commented Jun 17, 2023

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌


          chore: start env before running tests

7d7f602

vercel bot deployed to Preview – headstarwp

June 17, 2023 17:18

View deployment

Contributor

github-actions bot commented Jun 17, 2023

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

1 similar comment

Contributor

github-actions bot commented Jun 17, 2023

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌


          fix: update filter name

34f9e41

vercel bot deployed to Preview – headstarwp

June 17, 2023 18:19

View deployment

Contributor

github-actions bot commented Jun 17, 2023

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions bot added 2 commits

June 17, 2023 23:47


          test: more tests

70089e2


          chore: changeset

a4c19b6

nicholasio changed the title ~~feat: leverage html tag processor if available~~ feat: opt into html tag processor if available

vercel bot deployed to Preview – headstarwp

June 18, 2023 02:49

View deployment

nicholasio requested a review from tobeycodes

June 18, 2023 02:50

Contributor

github-actions bot commented Jun 18, 2023

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

tobeycodes approved these changes

View reviewed changes


          docs: add docs for gutenberg integration

65717a1

vercel bot deployed to Preview – headstarwp

June 18, 2023 16:15

View deployment

Contributor

github-actions bot commented Jun 18, 2023

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

nicholasio merged commit 4495ffe into develop

nicholasio deleted the feature/html-tag-processor branch

June 18, 2023 16:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet