Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos. #515

Merged
merged 5 commits into from
Jun 16, 2023
Merged

Fix typos. #515

merged 5 commits into from
Jun 16, 2023

Conversation

aaemnnosttv
Copy link
Member

@aaemnnosttv aaemnnosttv commented Jun 15, 2023

Description of the Change

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @aaemnnosttv

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2023

🦋 Changeset detected

Latest commit: c768912

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@headstartwp/headstartwp Patch
@headstartwp/core Patch
@headstartwp/next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headstarwp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2023 0:28am

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 120.23 KB (🟡 +2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (145 KB)
/ 7.97 KB 128.2 KB 88.42% (+/- <0.01%)
/[...path] 5.63 KB 125.87 KB 86.80% (🟡 +0.01%)
/author/[...path] 4.56 KB 124.79 KB 86.06% (+/- <0.01%)
/blog/[[...path]] 4.81 KB 125.04 KB 86.24% (+/- <0.01%)
/book/[...path] 5.63 KB 125.86 KB 86.80% (+/- <0.01%)
/books/[[...path]] 4.32 KB 124.55 KB 85.90% (+/- <0.01%)
/category/[...path] 4.73 KB 124.96 KB 86.18% (+/- <0.01%)
/tag/[...path] 4.76 KB 124.99 KB 86.20% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 120.23 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (145 KB)
/ 7.97 KB 128.2 KB 88.41% (🟡 +0.01%)
/[...path] 5.63 KB 125.86 KB 86.80% (+/- <0.01%)
/author/[...path] 4.56 KB 124.79 KB 86.06% (+/- <0.01%)
/blog/[[...path]] 4.81 KB 125.04 KB 86.24% (+/- <0.01%)
/book/[...path] 5.63 KB 125.86 KB 86.80% (+/- <0.01%)
/books/[[...path]] 4.32 KB 124.55 KB 85.90% (+/- <0.01%)
/category/[...path] 4.73 KB 124.96 KB 86.18% (+/- <0.01%)
/tag/[...path] 4.76 KB 124.99 KB 86.20% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Member Author

@aaemnnosttv aaemnnosttv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few of these changes are functionally-significant. I've flagged them below for review.

@@ -21,7 +21,7 @@ public function register() {
add_filter( 'the_content_feed', [ $this, 'filter_url' ], 999 );
add_filter( 'the_excerpt_rss', [ $this, 'filter_url' ], 999 );
add_filter( 'comments_link_feed', [ $this, 'filter_url' ], 999 );
add_filter( 'commnet_link', [ $this, 'filter_url' ], 999 );
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is a bit more significant as the hooked function wouldn't have worked before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Catch!

@@ -10,14 +10,14 @@ export interface PullQuoteBlockProps extends IBlockAttributes {
borderColor?: string;
}

export interface IPullQuotekBlock extends IBlock<PullQuoteBlockProps> {}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️

@@ -29,7 +29,7 @@ export interface Typography {
supportsCustomFontSize: boolean;
supportsFontWeight: boolean;
supportsLetterSpacing: boolean;
supportsLineHight: boolean;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️

@aaemnnosttv aaemnnosttv marked this pull request as ready for review June 15, 2023 19:33
@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 120.23 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (145 KB)
/ 7.97 KB 128.2 KB 88.41% (🟡 +0.01%)
/[...path] 5.63 KB 125.86 KB 86.80% (+/- <0.01%)
/author/[...path] 4.56 KB 124.79 KB 86.06% (+/- <0.01%)
/blog/[[...path]] 4.81 KB 125.04 KB 86.24% (+/- <0.01%)
/book/[...path] 5.63 KB 125.86 KB 86.80% (+/- <0.01%)
/books/[[...path]] 4.32 KB 124.55 KB 85.90% (+/- <0.01%)
/category/[...path] 4.73 KB 124.96 KB 86.18% (+/- <0.01%)
/tag/[...path] 4.76 KB 124.99 KB 86.20% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 120.23 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (145 KB)
/ 7.97 KB 128.2 KB 88.41% (🟡 +0.01%)
/[...path] 5.63 KB 125.86 KB 86.80% (+/- <0.01%)
/author/[...path] 4.56 KB 124.79 KB 86.06% (+/- <0.01%)
/blog/[[...path]] 4.81 KB 125.04 KB 86.24% (+/- <0.01%)
/book/[...path] 5.63 KB 125.86 KB 86.80% (+/- <0.01%)
/books/[[...path]] 4.32 KB 124.55 KB 85.90% (+/- <0.01%)
/category/[...path] 4.73 KB 124.96 KB 86.18% (+/- <0.01%)
/tag/[...path] 4.76 KB 124.99 KB 86.20% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@nicholasio nicholasio merged commit 62ac6b3 into develop Jun 16, 2023
@nicholasio nicholasio deleted the fix-typos branch June 16, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants