Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(revalidate): implements revalidate for post related terms #500

Closed
wants to merge 8 commits into from

Conversation

orballo
Copy link
Contributor

@orballo orballo commented Jun 11, 2023

Description of the Change

Closes #295

Child PR: #535

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @orballo

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly. (Will do in another PR, after post_type archives revalidation is implemented)
  • I have added tests to cover my change.
  • All new and existing tests pass.

TODO:

@changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2023

⚠️ No Changeset found

Latest commit: 7967202

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headstarwp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2023 6:07pm

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@orballo
Copy link
Contributor Author

orballo commented Jun 27, 2023

@nicholasio This PR is getting too big. Could you please review it?

I still need to add the revalidate for the post_type archives, modify the existing projects to use this functionality, and update the docs. But I want to do this in three different PRs.

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@orballo orballo changed the title feat(revalidate): implementation of archives revalidation [wip] feat(revalidate): implements revalidate for post related terms Jun 27, 2023
@orballo orballo self-assigned this Jun 27, 2023
@nicholasio nicholasio added this to the v1.1 milestone Jul 11, 2023
@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@nicholasio
Copy link
Member

I did some testing and couldn't get term archives to be revalidated. Next.js is returning missing params.

@orballo
Copy link
Contributor Author

orballo commented Jul 27, 2023

@nicholasio I didn't forget about this. I'll work on it as soon as I find some time.

@nicholasio nicholasio closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On-Demand Revalidation for archive pages
2 participants