Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional classes on Menu #570

Closed
1 task done
burhandodhy opened this issue Jul 27, 2023 · 1 comment · Fixed by #818
Closed
1 task done

Add additional classes on Menu #570

burhandodhy opened this issue Jul 27, 2023 · 1 comment · Fixed by #818
Assignees
@Sidsector9
Labels
good first issue Good for newcomers

Comments

@burhandodhy
Copy link

Is your enhancement related to a problem? Please describe.

At the moment, the menu item only has one class related to its depth. It would be beneficial to include additional classes such as menu-item-type-custom and menu-item-has-children.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@nicholasio
Copy link
Member

We haven't actually used this component in production, but happy to add improvements to it. Wanna submit a PR?

@nicholasio nicholasio added the good first issue Good for newcomers label Aug 25, 2023
@Sidsector9 Sidsector9 self-assigned this Jul 20, 2024
@Sidsector9 Sidsector9 mentioned this issue Jul 20, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sidsector9 Sidsector9

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat/570: Enhancements to menu item classes 10up/headstartwp
3 participants
@nicholasio @burhandodhy @Sidsector9