Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: combined queries with q parameter #392

Merged
merged 1 commit into from
May 8, 2024

Conversation

oscarssanchezz
Copy link
Collaborator

Description of the Change

Per Brightcove documentation: https://apis.support.brightcove.com/cms/searching/cms-and-playback-apis-video-search-v2.html, a + sign should be added to make the query string parameter mandatory.

This seems to be the only way to make search work with combined queries such as state:active-inactive.

Adding the parameter to the query does not affect single search term negatively.

Closes #

How to test the Change

Changelog Entry

Fixed - Bug fix: Add + sign to search term parameter for combined queries.

Credits

Props @oscarssanchezz

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@oscarssanchezz oscarssanchezz merged commit 3113725 into develop May 8, 2024
13 checks passed
@oscarssanchezz oscarssanchezz deleted the fix/filtering-inactive-active branch May 8, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants