Release 2.8.6 #391
Merged
Release 2.8.6 #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect into release/2.8.6
felipeelia
requested changes
May 7, 2024
CHANGELOG.md
Outdated
| @@ -13,6 +13,14 @@ All notable changes to this project will be documented in this file, per [the Ke | |||
| ### Security | |||
| --> | |||
|
|
|||
| ## [2.8.6] - 2023-05-07 | |||
There was a problem hiding this comment.
Suggested change
| ## [2.8.6] - 2023-05-07 | |
| ## [2.8.6] - 2024-05-07 |
There was a problem hiding this comment.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "brightcove-video-connect", | |||
| "version": "2.8.5", | |||
| "version": "2.8.6", | |||
There was a problem hiding this comment.
this also needs to be changed in line 9
There was a problem hiding this comment.
readme.txt
Outdated
Comment on lines
46
to
47
| - Cannot use Brightcove block on custom post types. Props [@spacedmonkey](https://github.com/spacedmonkey) and [@jonnynews](https://github.com/jonnynews). | ||
| - Typo when saving the language_detection attribute. Props [@claimableperc](https://github.com/claimableperc). |
There was a problem hiding this comment.
Can we make this list to start with * to line up with the previous ones?
There was a problem hiding this comment.
felipeelia
reviewed
May 8, 2024
CHANGELOG.md
Outdated
|
|
||
| - Cannot use Brightcove block on custom post types. Props [@spacedmonkey](https://github.com/spacedmonkey) and [@jonnynews](https://github.com/jonnynews) via [#389](https://github.com/10up/brightcove-video-connect/pull/389). | ||
| - Typo when saving the language_detection attribute. Props [@claimableperc](https://github.com/claimableperc) via [#390](https://github.com/10up/brightcove-video-connect/pull/390). | ||
| - Bugfix: combined queries with q search parameter. Props [@oscarssanchezz](https://github.com/oscarssanchezz/oscarssanchezz) via [#392](https://github.com/10up/brightcove-video-connect/pull/392). |
There was a problem hiding this comment.
Suggested change
| - Bugfix: combined queries with q search parameter. Props [@oscarssanchezz](https://github.com/oscarssanchezz/oscarssanchezz) via [#392](https://github.com/10up/brightcove-video-connect/pull/392). | |
| -Combined queries with q search parameter. Props [@oscarssanchezz](https://github.com/oscarssanchezz) via [#392](https://github.com/10up/brightcove-video-connect/pull/392). |
Your user is wrong and as it is already in the "Fixed" section, we don't need the "Bugfix" prefix ;)
There was a problem hiding this comment.
Fixed here: 0ad0309
felipeelia
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
PR Release for v.2.8.6
How to test the Change
Changelog Entry
Credits
N/A
Checklist: