Fix: Update call fail when labels are empty (#381)

10up · Mar 27, 2024 · 3527297 · 3527297
1 parent 879084c
commit 3527297
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/assets/js/src/views/video-edit.js b/assets/js/src/views/video-edit.js
@@ -385,7 +385,8 @@ var VideoEditView = BrightcoveView.extend({
 		this.model.set('captions', captions);
 
 		// Labels
-		const labels = this.$el.find('.bc-labels-value').val()?.split(',') || [];
+		let labels = this.$el.find('.bc-labels-value').val();
+		labels = labels !== '' ? labels.split(',') : [];
 		this.model.set('labels', labels);
 
 		// Custom fields

diff --git a/includes/admin/api/class-bc-admin-media-api.php b/includes/admin/api/class-bc-admin-media-api.php
@@ -173,7 +173,7 @@ public function bc_ajax_update_video_or_playlist() {
 
 		$labels = array();
 		if ( isset( $_POST['labels'] ) ) {
-			foreach ( $_POST['labels'] as $label ) {
+			foreach ( array_filter( $_POST['labels'] ) as $label ) {
 				$labels[] = sanitize_text_field( $label );
 			}
 		}