Fix: Floating Buttons - various fixes #5
Conversation
| height: var(--e-contact-buttons-icon-size-small); | ||
| width: var(--e-contact-buttons-icon-size-small); | ||
|
|
||
| svg { |
There was a problem hiding this comment.
@mserino just a thought here as I'm not overly familiar with this widget, but can the SVG height & width use the same custom properties e.g. --e-contact-buttons-icon-size-small or perhaps be set once as height: 100%, width: 100%; so match the container rather than resetting with each size variation?
There was a problem hiding this comment.
Yeah I'm hardcoding the values since they will always be depending on the size of the button, and they're decided by design. It didn't make much sense to create variables as they'll always have those size and they're fixed.
| &__contact-tooltip { | ||
| background-color: var(--e-contact-buttons-tooltip-bg); | ||
| border-radius: 16px; | ||
| box-shadow: 2px 4px 4px 0 rgba(0, 0, 0, 0.15); |
There was a problem hiding this comment.
Maybe use a more modern format for RGBA?
https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/rgb
There was a problem hiding this comment.
@willhowat this is the default box shadow that is coming out from the box shadow style controls. It's supposed to be overwritten anyway.
modules/conversion-center/classes/render/contact-buttons-render-base.php
Show resolved
Hide resolved
PR Checklist
PR Type
What kind of change does this PR introduce?
Summary
This PR can be summarized in the following changelog entry:
Description
An explanation of what is done in this PR
Test instructions
This PR can be tested by following these steps:
Quality assurance
Fixes #