Internal: Floating Buttons - Variation 10 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mserino
changed the title
willhowat
approved these changes
Jun 13, 2024
willhowat
reviewed
Jun 13, 2024
| @@ -22,7 +22,7 @@ public function get_name(): string { | |||
| } | |||
|
|
|||
| public function get_title(): string { | |||
| return esc_html__( 'Contact Buttons', 'elementor' ); | |||
| return esc_html__( 'Single chat', 'elementor' ); | |||
There was a problem hiding this comment.
@mserino just a thought, if the naming is changing we may need to look at aria-labels associated with toggle and close buttons across variants
There was a problem hiding this comment.
@willhowat thanks, good call! I've updated all the occurrences with something more generic
willhowat
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
Summary
This PR can be summarized in the following changelog entry:
Description
An explanation of what is done in this PR
Test instructions
This PR can be tested by following these steps:
Quality assurance
Fixes #