Update packages to fix Node 20 build failure

101100 · Jul 21, 2024 · a39de36 · a39de36
1 parent bfc6ba2
commit a39de36
Show file tree

Hide file tree

Showing 4 changed files with 944 additions and 1,365 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -13,7 +13,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [14.x, 16.x]
+        node-version: [14.x, 16.x, 20.x]
 
     steps:
       - uses: actions/checkout@v3

diff --git a/helpers.ts b/helpers.ts
@@ -284,7 +284,7 @@ export function parseNumberOrString(str?: string): number | string {
 
     const num = parseFloat(str);
 
-    return num === NaN ? str : num;
+    return Number.isNaN(num) ? str : num;
 }
 
 

diff --git a/package.json b/package.json
@@ -36,14 +36,14 @@
     "node": ">= 8.0.0"
   },
   "devDependencies": {
-    "@serialport/parser-readline": "^8.0.6",
-    "@types/mocha": "^7.0.2",
-    "@types/serialport": "^8.0.0",
-    "mocha": "^7.1.1",
-    "serialport": "^8.0.7",
+    "@serialport/parser-readline": "^12.0.0",
+    "@types/mocha": "^10.0.7",
+    "@types/serialport": "^8.0.5",
+    "mocha": "^10.7.0",
+    "serialport": "^12.0.0",
     "should": "^13.2.3",
     "tslint": "^6.1.1",
-    "typescript": "^3.8.3"
+    "typescript": "^5.5.3"
   },
   "dependencies": {}
 }