sdk(prog_id): Use a single Poseidon2HashType to represent a ProgramIdentifier
#1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ProgramIdentifier` This commit updates `Poseidon2HashType` to represent 32 bytes instead of the current 4 bytes to be secure enough for production use; the previous 4 bytes were just for initial testing purposes. This also entails changes with the `ProgramIdentifier` type, which now is just represented by a single `Poseidon2HashType`, but is still formed by the program rom hash, the memory init hash, and the entrypoint like before - these values are hashed once to form a program's `ProgramIdentifier`. With this we also remove `hash.rs` from `guest` crate since we move its functions over to the sdk now.
spiral-ladder
force-pushed
the
bing/refactor-prog-id
branch
from
88c4011 to
91c0362
Compare
spiral-ladder
commented
Mar 11, 2024
| use crate::sys::poseidon2_hash; | ||
|
|
||
| let input = chain!( | ||
| program_rom_hash.to_le_bytes(), |
There was a problem hiding this comment.
Those are conceptually already field elements. Does it make sense to go back to bytes?
(Probably it doesn't make a difference?)
matthiasgoergens
approved these changes
Mar 11, 2024
supragya
approved these changes
Mar 11, 2024
| use crate::coretypes::DIGEST_BYTES; | ||
|
|
||
| // VM expects input length to be multiple of RATE | ||
| assert!(input.len() % RATE == 0); |
There was a problem hiding this comment.
Maybe add a similar assert on native execution too?
We need to hash some content from event tape in order to generate canonical event tape. The assert might be handy to detect that we forgot to pad.
Eventually maybe we should work on adding the functionality to hash input of size which is not multiple of RATE.
There was a problem hiding this comment.
Sure, let's do that.
codeblooded1729
approved these changes
Mar 11, 2024
Co-authored-by: Kapil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1343
This commit updates
Poseidon2HashTypeto represent 32 bytes instead of the current 4 bytes to be secure enough for production use; the previous 4 bytes were just for initial testing purposes.This also entails changes with the
ProgramIdentifiertype, which now is just represented by a singlePoseidon2HashType, but is still formed by the program rom hash, the memory init hash, and the entrypoint like before - these values are hashed once to form a program'sProgramIdentifier.With this we also remove
hash.rsfromguestcrate since we move its functions over to the sdk now.