chore: Update web-client API and remove off/on chain references #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igamigo
force-pushed
the
igamigo-note-scripts-wasm
branch
from
4bbd530 to
cdc5137
Compare
igamigo
changed the title
igamigo
force-pushed
the
igamigo-note-scripts-wasm
branch
from
c7be47e to
7357286
Compare
dagarcia7
reviewed
Jan 23, 2025
| @@ -20,6 +20,9 @@ use crate::{ | |||
| transactions::{TransactionRecord, TransactionStoreUpdate}, | |||
| }; | |||
|
|
|||
| #[cfg(not(target_arch = "wasm32"))] | |||
| compile_error!("The `idxdb` feature is only supported when targeting wasm32."); | |||
dagarcia7
reviewed
Jan 23, 2025
crates/web-client/README.md
Outdated
There was a problem hiding this comment.
I think the changes in here are fine, but since I haven't paid too much attention to the docs lately, I was looking at TypeDoc to see if we can just automatically generate documentation for the SDK calls from the Typescript typings. We can even add any additional context we want as rust docs on the web client calls and it should show up in the typings .d.ts file and ultimately in the auto-generated docs. Doesn't have to be in this PR, but something to think about for a near future issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes the
idxdbstore only compile for WASM targets