feat: Use AccountComponentTemplate
#680
Conversation
igamigo
force-pushed
the
igamigo-block-num
branch
from
f69fdf5 to
1bee2f7
Compare
igamigo
changed the title
AccountComponentTemplate
igamigo
force-pushed
the
igamigo-component-template
branch
4 times, most recently
from
b4ae4b1 to
3ed6e41
Compare
igamigo
force-pushed
the
igamigo-component-template
branch
from
568c3ca to
40baa5a
Compare
| #[derive(Debug, Parser, Clone)] | ||
| /// Create a new wallet account. | ||
| pub struct NewWalletCmd { |
There was a problem hiding this comment.
Same nit as above re putting comments above attributes.
There was a problem hiding this comment.
I actually meant docs/attributes on lines 213 - 214 (not for the internal fields). Re-arranging them for the fields is fine too - but let's make sure the descriptions still show up in the CLI correctly.
| /// Helper function to process extra component templates. | ||
| /// It reads user input for each placeholder in a component template. | ||
| // TODO: this could take a TOML file with key-values | ||
| fn process_component_templates( | ||
| extra_components: &[AccountComponentTemplate], | ||
| ) -> Result<Vec<AccountComponent>, CliError> { | ||
| let mut account_components = vec![]; | ||
| for component_template in extra_components { | ||
| let mut init_storage_data = BTreeMap::new(); | ||
| for (placeholder_key, placeholder_type) in | ||
| component_template.metadata().get_unique_storage_placeholders() | ||
| { | ||
| print!( | ||
| "Enter hex value for placeholder '{}' (type: {}): ", | ||
| placeholder_key, placeholder_type | ||
| ); | ||
| std::io::stdout().flush()?; | ||
|
|
||
| let mut input_value = String::new(); | ||
| std::io::stdin().read_line(&mut input_value)?; | ||
| let input_value = input_value.trim(); |
There was a problem hiding this comment.
This approach is fine for this PR, but it is actually different from how I originally thought about it. Specifically, I was imagining that we'd prompt the user to provide data for specific fields and so we'd show a filed name and a field description to the user (rather than showing placeholder and type).
This may require refactoring the structure in miden-base - maybe to move away from placeholder-based approach and more toward specifying something like a "type" or a "kind" for a given storage slot. Let's create an issue for this.
There was a problem hiding this comment.
I see. I think we could show the storage slot metadata here (name and description), but not specifically for the values themselves although the placeholder itself does not carry this data (so it would have to be searched in the template metadata). Is this what you meant? Or did you mean more specific to the value?
There was a problem hiding this comment.
I think ideally we'd iterate over all slots that require user input, show slot name/description, and allow user to enter the required values (there may be more than one value needed per slot). What we now call placeholder may need to be treated more like a "type" of the data. For example, we may have 3 slots each expecting Falcon public keys and so all 3 would have type auth::rpo_falcon512 (or something like this) - but the user should be able to provide 3 different public keys.
There are a few details to think through here - so, probably warrants a separate issue.
| #[derive(Debug, Parser, Clone)] | ||
| /// Create a new wallet account. | ||
| pub struct NewWalletCmd { |
There was a problem hiding this comment.
I actually meant docs/attributes on lines 213 - 214 (not for the internal fields). Re-arranging them for the fields is fine too - but let's make sure the descriptions still show up in the CLI correctly.
No description provided.