Transaction Tests #569
Transaction Tests #569
Conversation
CHANGELOG.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| ## 0.6.0 (TBD) | |||
|
|
|||
| * Add Transaction Integration Tests for Web Client (#569). | |||
There was a problem hiding this comment.
We should use past tense in the changelog:
| * Add Transaction Integration Tests for Web Client (#569). | |
| * Added Transaction Integration Tests for Web Client (#569). |
| let transactions = await client.get_transactions(window.TransactionFilter.all()); | ||
| let uncomittedTransactions = await client.get_transactions(window.TransactionFilter.uncomitted()); | ||
| let transactionIds = transactions.map(transaction => transaction.id().to_hex()); | ||
| let uncomittedTransactionIds = uncomittedTransactions.map(transaction => transaction.id().to_hex()); |
There was a problem hiding this comment.
Are we able to call getAllTransaction here? The one defined above
There was a problem hiding this comment.
Yes we are! I also changed the "no transactions" test to just use that as well.
| compileTxScript(script) | ||
| ).to.be.rejectedWith(`Failed to compile transaction script: Transaction script error: AssemblyError("invalid syntax")`); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
End of file is missing here
dagarcia7
force-pushed
the
transaction-tests
branch
2 times, most recently
from
d9874db to
95842ea
Compare
|
Once 0xPolygonMiden/miden-base#951 gets merged, the CI can be re-run since the WASM build should be fixed |
|
@igamigo sounds good thanks for the heads up! In the meantime, the rest of the feedback has been addressed @tomyrd @SantiagoPittella 🙌 |
|
@dagarcia7 can you rebase your fork from |
dagarcia7
force-pushed
the
transaction-tests
branch
3 times, most recently
from
e6b971f to
3570c3a
Compare
|
@igamigo rebased and all looks good now! 🙌 Thanks! |
| await new Promise((r) => setTimeout(r, 20000)); // TODO: Replace this with loop of sync -> check uncommitted transactions -> sleep | ||
| await client.sync_state(); | ||
| if (_sync) { | ||
| await new Promise((r) => setTimeout(r, 20000)); // TODO: Replace this with loop of sync -> check uncommitted transactions -> sleep |
There was a problem hiding this comment.
Would be very nice to address this with a function that the whole test suite can call, in order to minimize execution time.
There was a problem hiding this comment.
Yes! This has been on my mind a lot as well. Let me merge in this PR, and will follow up with this immediately 🫡
Summary
This PR adds integration tests for the
get_transactionsandcompile_tx_scriptweb client calls intransactions.rs.