feat: TestDecodeErigonStateSyncReceipt #1819
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
marcello33
approved these changes
Oct 14, 2025
manav2401
reviewed
Oct 14, 2025
| t.Fatal("Empty RLP bytes") | ||
| } | ||
|
|
||
| var data storedReceiptRLP |
There was a problem hiding this comment.
It would be good if we can decode based on how it's done here using ReceiptList where you can explicitly use ReceiptList69 struct instead of the generic parameter L.
| receiptType := LegacyTxType | ||
|
|
||
| // Verify it's a state sync receipt (CumulativeGasUsed = 0). | ||
| if data.CumulativeGasUsed != 0 { |
There was a problem hiding this comment.
This is only the case if block only contained state-sync receipt and nothing else. It would be good if we can include a case which has normal receipts + state-sync receipts. In that case, the cumulative gas field in state-sync receipt would be equal to the value in last normal receipt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TestDecodeErigonStateSyncReceiptverifies that Bor can decode state sync receipts sent by Erigon nodes over P2P usingeth/69protocol. The RLP data is captured from actual Erigon state sync receipt generation.