Add reject for unknown server_name to prevent malicious DNS #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add reject for unknown server_name to prevent malicious DNS
Hintay
force-pushed
the
dev
branch
6 times, most recently
from
6c465ea to
8da309b
Compare
0xJacky
force-pushed
the
dev
branch
2 times, most recently
from
e91ea6b to
013d810
Compare
Hintay
force-pushed
the
dev
branch
10 times, most recently
from
646b44b to
eb89065
Compare
Hintay
force-pushed
the
dev
branch
4 times, most recently
from
9bf7370 to
8c72156
Compare
|
As your PR made a breaking change for existing users. Some users may visit IP directly to manage their server. After a few months decision, I decided not to merge this PR. However, for users who have the same requirement as you, I added a config template in 76ea178 called "Reject Empty Host", they can add this directive to their config manually. By the way, if we don't want to be visited via malicious DNS, we don't need to listen the 443 ports for the default server.
|
|
Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reject for unknown server_name to prevent malicious DNS