Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ctfnote setup to config file #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move ctfnote setup to config file #12

wants to merge 1 commit into from

Conversation

ViRb3
Copy link
Contributor

@ViRb3 ViRb3 commented Aug 24, 2023

Not sure about your thoughts on this one, but it makes the bot truly stateless and ctfnote works without any manual configuration even after restart.

@lucidBrot
Copy link
Member

lucidBrot commented Aug 25, 2023

I agree that loading the auth from a file is way cleaner. It's something I also though to do, but then never did. ( #5 )
Points to be careful with:

  • The bot should still start up correctly even if the ctfnote server is not reachable, failing auth, whatever... . It does not look to me like your changes will have issues with this though.
  • For the same reasons, I want to keep the commands to modify the server auth at runtime.

It's always useful to be able to fix the setup even if robin and cyan are asleep.

@RobinJadoul
Copy link
Member

Agreed with both sentiments here:

  • it's nice to have the default in the config file
  • it's nice to have a manual escape hatch to update it
  • maybe it's also nice to be able to reload the config from disk to go back to default (maybe as a separate changeset)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants