Fix wrong token unit checking #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabasov
added a commit
that referenced
this pull request
Dec 19, 2023
* feature: synchronized up-to-date DEX bridge interface * feature: updated gosdk version * fix: fixed bugs * fix: fixed bugs * Silent the zcnbridge verbose logs when `--silent * use 0box-sdk logger for zcnbridge (#304) * update gosdk * update gosdk * update gosdk, fix errors * Update/self hosted runner (#308) * update self hosted runner * updated self hosted runner * updated gosdk * updated gosdk * updated gosdk * update gosdk * use msys2 to build windows binaries (#317) * use msys2 to build windows binaries * add build-windows in release-wallet.yml * add actions checkout * Feature: integrate token swap logic into WZCN burn command (#316) * feature: added swap logic * feature: added swap logic for burn wzcn command * fix: replaced gosdk * fix: fixed bugs * fix: fixed bugs * feature: replaced confusing param naming * fix: updated gosdk version --------- Co-authored-by: Yury <[email protected]> * Fix wrong unit compare (#318) * Add option to mint-zcn for specific burn txn (#322) * Fix: add different naming for the different results of Bridge operations (#324) * fix: added different result messaging for different cases of bridge operations * fix: debug line * fix: removed debug line * Feature: add reset nonce command (#329) * feature: add reset nonce command * fix: remove debug gosdk version * feature: update gosdk version * update gosdk (#326) * update gosdk * revert useless changes --------- Co-authored-by: Yury <[email protected]> * updated gosdk * add runner (#321) Co-authored-by: Manohar Reddy <[email protected]> * update gosdk (#331) * Feature: add BNT, USDC and EURC tokens for Swap (#327) * feature: add multiple tokens for swap * feature: fixed ERC20 approve * feature: made DEX operations consistent with web-apps * fix: fixed swap approval * feature: update go.mod * fix: fixed bug * feature: updated gosdk * Updated gosdk (#332) * Add option to select eth address index (#333) * Add --account_index option (#334) * Add bip32 option to import account (#335) * Feature: implement fork per run strategy (#336) * feature: added fork creation * feature: improved Tenderly creation flow * update gosdk (#337) * feature: added custom block number during Tenderly fork creation (#340) * upgrade GoSDK to sprint-1.11 (#339) Co-authored-by: service-0chain <[email protected]> * upgrade GoSDK to sprint-1.11 (#341) Co-authored-by: service-0chain <[email protected]> * upgrade GoSDK to sprint-1.11 (#342) Co-authored-by: service-0chain <[email protected]> * upgrade GoSDK to sprint-1.11 (#343) Co-authored-by: service-0chain <[email protected]> * update gosdk to v1.11.0 (#347) --------- Co-authored-by: YarikRevich <[email protected]> Co-authored-by: Yaroslav Svitlytskyi <[email protected]> Co-authored-by: Yaroslav Svitlytskyi <[email protected]> Co-authored-by: peterlimg <[email protected]> Co-authored-by: Manohar Reddy <[email protected]> Co-authored-by: shahnawaz-creator <[email protected]> Co-authored-by: dabasov <[email protected]> Co-authored-by: peterlimg <[email protected]> Co-authored-by: Ebrahim Gomaa <[email protected]> Co-authored-by: Tapish Sinha <[email protected]> Co-authored-by: Jayash Satolia <[email protected]> Co-authored-by: service-0chain <[email protected]> Co-authored-by: service-0chain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A brief description of the changes in this PR:
In
bridge-burn-eth, we check if the current token balance amount is greater than the amount to burn. But it used wrong token unit, the token balance was in ZCN, but theamountis in SAS.Tasks to complete before merging PR:
Associated PRs (Link as appropriate):