Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gosdk for storage v2 #161

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Update gosdk for storage v2 #161

merged 6 commits into from
Oct 21, 2024

Conversation

Hitenjain14
Copy link
Member

Description

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

@Hitenjain14 Hitenjain14 changed the base branch from staging to sprint-1.18 October 19, 2024 07:12
@Hitenjain14 Hitenjain14 marked this pull request as ready for review October 20, 2024 06:58
@Hitenjain14 Hitenjain14 changed the title update gosdk Update gosdk for storage v2 Oct 20, 2024
dabasov
dabasov approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 4d8f487 into sprint-1.18 Oct 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hitenjain14 @dabasov