Methods mig to zbox #1685
Methods mig to zbox #1685
Conversation
Sprint 1.18
Add method for wasm type
smaulik13
requested review from
peterlimg,
dabasov and
guruhubb
as code owners
core/client/set.go
Outdated
| @@ -324,6 +326,7 @@ func InitSDK(walletJSON string, | |||
| return err | |||
| } | |||
| SetSdkInitialized(true) | |||
| node.SetIsWasm(true) | |||
There was a problem hiding this comment.
We can't force it for everyone using gosdk.
Set it in wasm initialisation and mobile initialisation (we need to use it on mobile as well, perhaps change the name to something resonable).
There was a problem hiding this comment.
This InitSdk method is being called from both sdks only.
There was a problem hiding this comment.
But it is called from other repos using gosdk as well. We need to get it in input. Gosdk is used in 0box, blobber, CLIs and 0chain. Everywhere it can't use 0box.
zcncore/get_data.go
Outdated
| @@ -177,7 +181,7 @@ func GetMinerSCNodeInfo(id string) ([]byte, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| return client.MakeSCRestAPICall(MinerSmartContractAddress, GET_MINERSC_NODE, Params{ | |||
| return node.MakeSCRestAPICallToSharder(MinerSmartContractAddress, GET_MINERSC_NODE, Params{ | |||
There was a problem hiding this comment.
Can we not use 0box calls here? If not why?
There was a problem hiding this comment.
This is not used by any sdk (wasm or mobile).
zcncore/get_data.go
Outdated
| } | ||
|
|
||
| func GetMiners(active, stakable bool, limit, offset int) ([]byte, error) { | ||
| if err := CheckConfig(); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return client.MakeSCRestAPICall(MinerSmartContractAddress, GET_MINERSC_MINERS, Params{ | ||
| return node.MakeSCRestAPICallToSharder(MinerSmartContractAddress, GET_MINERSC_MINERS, Params{ |
There was a problem hiding this comment.
Still we can use "MakeSCRestAPICall" to protect in future. It will not create any problem right?
There was a problem hiding this comment.
These are not implemented in zbox
zcncore/get_data.go
Outdated
| @@ -213,7 +220,7 @@ func GetSharders(active, stakable bool, limit, offset int) ([]byte, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| return client.MakeSCRestAPICall(MinerSmartContractAddress, GET_MINERSC_SHARDERS, Params{ | |||
| return node.MakeSCRestAPICallToSharder(MinerSmartContractAddress, GET_MINERSC_SHARDERS, Params{ | |||
There was a problem hiding this comment.
Same here and in multiple places in same file.
Changes
Fixes
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):