Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/refactor zboxcore mobilesdk fixes #1633

Open
wants to merge 80 commits into
base: staging
Choose a base branch
from

Conversation

yash10019coder
Copy link
Member

@yash10019coder yash10019coder commented Oct 4, 2024

Changes

  • expose GetBlobbers method.

  • expose GetStorageConfig method.
    expose GetVersion method.

  • expose ConvertToValue method.

  • exposed staking, unstaking and collect reward methods for miners, sharders and blobbers.
    exposed Faucet method.

  • expose GetStakePoolUserInfo.

  • Fix

  • Setup auth

  • fix: fixed restriction setup

  • fix: fixed bugs

  • fix: fixed bugs

  • fix: fixed bugs

  • fix: fixed bugs

  • fix: fixed bugs

  • Fix

  • add docs for expose GetStakePoolUserInfo method.

  • expose VerifyTransaction method.

  • expose GetTransactions method in gosdk.

  • expose GetFeesTable method.

  • fix: error initializing sdk.

  • fix: GetTransactions method.

  • fix: init_node.go network initialization.

  • fix: sdk not initialized error for zboxcore methods.

  • refactor: add provider type field in StakePoolDelegatePoolInfo.

  • debug: mobile build flagsin mobilesdk/sdk.go.

  • debug: playground script.

  • refactor: combined blobber and miner/sharder user stake pool info.

  • go mod tidy

  • fix: add provider id in StakePoolDelegatePoolInfo.

  • expose: GetConfig method.

  • remove faucet method from mobilesdk.

  • fix: InitStorageSDK method error.

  • refactor: add custom fees to all of the mobilesdk methods for staking, unstaking and claim rewards.

  • refactor: add fees in sendZCN.

  • fix: wasmsdk send token to pass fee parameter.

  • expose: client.Sign
    expose: sdk.GetClientEncryptedPublicKey
    expose: CreateThumbnail method.


Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • 0chain:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

mobilesdk/zcn/execute_transactions.go Outdated Show resolved Hide resolved
zcncore/execute_transactions.go Outdated Show resolved Hide resolved
zcncore/execute_transactions.go Outdated Show resolved Hide resolved
zcncore/get_data.go Show resolved Hide resolved
zcncore/get_data.go Show resolved Hide resolved
…om zboxcore.

refactor: remove separate methods for staking, unstaking and collect rewards from zboxcore/execute_transactions.go
expose: GetValidatorByID.
Copy link
Collaborator

@Jayashsatolia403 Jayashsatolia403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jayashsatolia403 Jayashsatolia403 changed the base branch from sprint-1.18 to staging November 13, 2024 22:33
Copy link
Collaborator

@Jayashsatolia403 Jayashsatolia403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

zcncore/execute_transactions.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants