Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use 0box-sdk logger for zcnbridge #1209

Closed
wants to merge 2 commits into from
Closed

use 0box-sdk logger for zcnbridge #1209

wants to merge 2 commits into from

Conversation

boddumanohar
Copy link
Contributor

@boddumanohar boddumanohar commented Sep 6, 2023 •
edited
Loading

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

Hitenjain14 and others added 2 commits September 3, 2023 22:36
@Hitenjain14
Refactor multi upload (#1204)
58ca971 
* refactor multi upload

* use removeProgress

* rmv progress on err
@boddumanohar
use 0box-sdk logger for zcnbridge
ecdef6f
@boddumanohar boddumanohar changed the base branch from staging to sprint-1.11 September 6, 2023 16:16
@boddumanohar boddumanohar mentioned this pull request Sep 6, 2023
Merged
3 tasks
@boddumanohar boddumanohar linked an issue Sep 6, 2023 that may be closed by this pull request
Silent the zcnbridge logs when --silent is enabled #1206
Closed
@boddumanohar
Copy link
Contributor Author

already fixed by: #1207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

@dabasov dabasov Awaiting requested review from dabasov dabasov is a code owner

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

@cnlangzi cnlangzi Awaiting requested review from cnlangzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Silent the zcnbridge logs when --silent is enabled
2 participants
@boddumanohar @Hitenjain14