Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp changes #1210

Merged
merged 16 commits into from
Aug 18, 2023
Merged

Timestamp changes #1210

merged 16 commits into from
Aug 18, 2023

Conversation

Hitenjain14
Copy link
Member

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #1210 (d0afe0f) into staging (c2320d9) will decrease coverage by 0.01%.
Report is 2 commits behind head on staging.
The diff coverage is 16.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           staging    #1210      +/-   ##
===========================================
- Coverage    25.45%   25.45%   -0.01%     
===========================================
  Files           83       83              
  Lines         9274     9277       +3     
===========================================
  Hits          2361     2361              
- Misses        6622     6625       +3     
  Partials       291      291              
Flag Coverage Δ
Unit-Tests 25.45% <16.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ain.net/blobbercore/allocation/allocationchange.go 0.00% <ø> (ø)
...ode/go/0chain.net/blobbercore/allocation/entity.go 0.00% <ø> (ø)
...e/go/0chain.net/blobbercore/allocation/protocol.go 0.00% <0.00%> (ø)
...ain.net/blobbercore/handler/file_command_upload.go 40.68% <ø> (-0.41%) ⬇️
...et/blobbercore/handler/object_operation_handler.go 18.64% <0.00%> (ø)
.../go/0chain.net/blobbercore/writemarker/protocol.go 0.00% <0.00%> (ø)
...ode/go/0chain.net/blobbercore/filestore/storage.go 39.07% <100.00%> (+0.09%) ⬆️

@Hitenjain14 Hitenjain14 marked this pull request as draft August 16, 2023 17:41
@Hitenjain14 Hitenjain14 changed the base branch from sprint-july-4 to staging August 17, 2023 14:37
@Hitenjain14 Hitenjain14 marked this pull request as ready for review August 17, 2023 17:33
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov changed the base branch from staging to sprint-1.10 August 17, 2023 19:42
@service-0chain
Copy link
Collaborator

Manual system tests [cancelled] with the following config

config value
tests skipped false
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli
0chain
blobber fix/timestamp-changes
authorizer
0box
0dns

@dabasov dabasov merged commit c05cb20 into sprint-1.10 Aug 18, 2023
@dabasov dabasov deleted the fix/timestamp-changes branch August 18, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants