Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get ref #1203

Merged
merged 3 commits into from
Aug 13, 2023
Merged

Fix get ref #1203

merged 3 commits into from
Aug 13, 2023

Conversation

Hitenjain14
Copy link
Member

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@Hitenjain14 Hitenjain14 changed the base branch from staging to sprint-july-4 August 10, 2023 14:28
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #1203 (eb276ef) into sprint-july-4 (d14239b) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                Coverage Diff                @@
##           sprint-july-4    #1203      +/-   ##
=================================================
- Coverage          25.33%   25.32%   -0.02%     
=================================================
  Files                 82       82              
  Lines               9215     9220       +5     
=================================================
  Hits                2335     2335              
- Misses              6590     6595       +5     
  Partials             290      290              
Flag Coverage Δ
Unit-Tests 25.32% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../0chain.net/blobbercore/reference/referencepath.go 0.00% <0.00%> (ø)

@service-0chain
Copy link
Collaborator

Manual system tests [cancelled] with the following config

config value
tests skipped false
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli
0chain
blobber fix/get-ref
authorizer
0box
0dns

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli
0chain
blobber fix/get-ref
authorizer
0box
0dns

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped false
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli
0chain
blobber fix/get-ref
authorizer
0box
0dns

@dabasov dabasov merged commit 4f2674d into sprint-july-4 Aug 13, 2023
7 checks passed
@dabasov dabasov deleted the fix/get-ref branch August 13, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants