Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After transfer of repo. Modified references to new repo URL #1217

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hemulin
Copy link
Collaborator

@hemulin hemulin commented Dec 26, 2022

No description provided.

Copy link

@MichaelZelbel MichaelZelbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@nourspace nourspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but I wasn't able to understand why some of the CI jobs are failing.
Trying to build binaries from the branch to confirm.

@nourspace
Copy link

Few suggestions

@nourspace
Copy link

I built the branch hemulin:main and was able to run my validator
image

@nourspace
Copy link

I created a batch to your main branch @hemulin
hemulin#1

Please run the ci jobs and see whether the issue (installing openssl) is fixed. If so, you could merge the batch to your branch and hopefully the ci jobs run here as well.

We could also merge this PR and I would create another PR against the updated main. same same ^^

fix(ci): install libssl-dev as it seems missing for CI jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants