feat(vdf): Dynamic VDF and throttling of proofs from testnet to mainnet #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
99% of the changes are simply my autoformatter removing empty spaces. The only changes are in |
The1OneID
reviewed
Nov 13, 2022
| @@ -146,7 +146,7 @@ module Globals { | |||
| // target transaction per sec max gas: 20 | |||
| // uses "scaled representation", since there are no decimals. | |||
| subsidy_ceiling_gas: 8640000 * COIN_SCALING_FACTOR, // subsidy amount assumes 24 hour epoch lengths. Also needs to be adjusted for coin_scale the onchain representation of human readable value. | |||
| vdf_difficulty_baseline: 120000000, // FYI approx 30 mins per proof on 2020 macbook pro 2.5 ghz quadcore | |||
| vdf_difficulty_baseline: 160000000, // FYI approx 30 mins per proof on 2020 macbook pro 2.5 ghz quadcore | |||
There was a problem hiding this comment.
Prob this comment is no longer true, right?
There was a problem hiding this comment.
Good point. Will update once I get the final confirmation for the best value to set.
|
@hemulin Can you confirm if the Dynamic VDF changes and difficulty have made it to production on V5. And if so, if the migration to V6 is also including them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created v5.3 branch with the VDF changes.
Steps before merge: