Refactor clone usage in CLI node folder #1175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First commit Reformat .clone to .to_owned was done due to some research. I found that when trying to use a reference for these EventHandles I couldn't due to not being able to borrow a mutable reference twice. This may be a good discussion point for the guild based on lifetimes. Some resources I found are here and here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is to refactor some
.clonesas part of the Tool Scrubbers Guild Tasks. It contains 15 instances of.clone()cleanup. Some may not be applicable but would be good material for the Guild meeting. See commentsTest Plan
cargo testRelated PRs
N/A