Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #354

Merged
merged 7 commits into from
Oct 13, 2024
Merged

Update README.md #354

merged 7 commits into from
Oct 13, 2024

Conversation

neeru24
Copy link
Contributor

@neeru24 neeru24 commented Oct 12, 2024

📸 Fixed Screenshot Display & Added Repo Metrics

  • Fixed the issue where screenshots weren't displaying correctly.

  • Added a table to showcase important repository metrics like:

⭐ Number of stars
🍴 Number of forks
🐞 Number of issues
🔄 Number of pull requests

  • Included a new section highlighting Contributors 👥.

  • Added a call-to-action section encouraging users to star the repo ⭐!

Kindly merge it and assign me labels too @akbatra567

closes #134

Before:

Screenshot 2024-10-12 123039

After

Screenshot 2024-10-12 122839
Screenshot 2024-10-12 122853
Screenshot 2024-10-12 122912
Screenshot 2024-10-12 122920

README.md Outdated
Comment on lines 28 to 29
<img src = "https://github.com/neeru24/Connect_icons/blob/main/Screenshot%202024-10-12%20105220.png" alt = "image">
<img src = "https://github.com/neeru24/Connect_icons/blob/main/Screenshot%202024-10-12%20120929.png" alt = "image">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using url from your github account, download images in the repo and use local url paths to show the images.

Copy link
Contributor Author

@neeru24 neeru24 Oct 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using url from your github account, download images in the repo and use local url paths to show the images.

Actually I was trying to do so, but it's showing some restrictions that's why, I did so.. Isn't it fine? @akbatra567

@akbatra567 akbatra567 added status: requested-changes PR / Issues is reviewed and asked for some changes gssoc-ext GSSoC'24-Extd level1 labels Oct 13, 2024
@neeru24
Copy link
Contributor Author

neeru24 commented Oct 13, 2024

@akbatra567 Sorry, actually by mistake, i clicked on "resolve conversation" but the changes that you requested for the images to add as local path. I'm not not able to do so, It's saying you do not have permissions to add images and if I try to add the local path from my laptop, it's showing errors and images are not getting displayed.. Any suggestion for the same?

image

@akbatra567
Copy link
Collaborator

@akbatra567 Sorry, actually by mistake, i clicked on "resolve conversation" but the changes that you requested for the images to add as local path. I'm not not able to do so, It's saying you do not have permissions to add images and if I try to add the local path from my laptop, it's showing errors and images are not getting displayed.. Any suggestion for the same?

image

Here are the steps you need to do:

  1. Go to the forked version of the repo not this repo, you won't have access to directly upload. Link is here: https://github.com/neeru24/CabRental/tree/patch-1

  2. Either clone this repo and then add the files in the directory and run in local to validate if it is looking fine.

  3. If you're directly using online editor drag and drop images in the directory and then make changes to pick images from local path and first validate if it is working fine.

@neeru24
Copy link
Contributor Author

neeru24 commented Oct 13, 2024

Done with the changes. @akbatra567

@akbatra567 akbatra567 added PR merged Label for tracking issues with PR merged and removed status: requested-changes PR / Issues is reviewed and asked for some changes labels Oct 13, 2024
@akbatra567 akbatra567 merged commit 2e89b5f into 07sumit1002:main Oct 13, 2024
2 checks passed
@akbatra567
Copy link
Collaborator

Thanks @neeru24, merged the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext GSSoC'24-Extd level1 PR merged Label for tracking issues with PR merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancing Readme.md
2 participants