Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 112 - Complicated file structure (solved) #241

Closed

Conversation

DarshanKrishna-DK
Copy link
Contributor

@DarshanKrishna-DK DarshanKrishna-DK commented Oct 6, 2024

Issue 112 - Complicated file structure (solved)

Description

This pull request addresses the issue of a complex file structure in the project. By reorganizing the files into more logical categories (HTML, CSS, JavaScript, and PHP files), I have improved code readability and maintainability.

Type of Change

  • File Structure Simplification: Categorized similar files into their respective folders, enhancing project organization.
  • Updated File Paths: Adjusted image and file paths within the code to reflect the new file structure, ensuring accurate references.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings or errors

(Request you to consider this pull request and add hacktoberfest & gssoc lables. Thank you!)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@07sumit1002
Copy link
Owner

{8F1E7459-4EC8-4167-AB8E-D1DA4B01CC42}
This is having some conflicts, resolve and then recreate the PR
Pull the latest code and then work on it

@DarshanKrishna-DK
Copy link
Contributor Author

DarshanKrishna-DK commented Oct 7, 2024

Hey @07sumit1002. The merge conflicts will keep on arising because i have changed the file structure and hence the file & image paths are also modified.

So do not accept any pull request until today EOD. I will solve the merge conflicts and create a new pull request. Do make sure that you check my mofified pull request before any other, if not the merge conflicts will again arise.

(POV: This is the 3rd time i am resolving merge conflicts for this issue. Hope you understand)

@07sumit1002
Copy link
Owner

@DarshanKrishna-DK Ok From this point on i am not merging any PRs for the next 24 hrs.

@DarshanKrishna-DK
Copy link
Contributor Author

@DarshanKrishna-DK Ok From this point on i am not merging any PRs for the next 24 hrs.

Ok thank you!
Will create a new pull request by tomorrow 7AM.

@DarshanKrishna-DK DarshanKrishna-DK deleted the wob-issue-112 branch October 7, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants