Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base class for handlers #174

Closed
edwardcapriolo opened this issue Mar 31, 2013 · 5 comments
Closed

Base class for handlers #174

edwardcapriolo opened this issue Mar 31, 2013 · 5 comments

Comments

@edwardcapriolo
Copy link
Collaborator

Handlers need a base class that can deal with runtime exceptions.

@zznate
Copy link
Owner

zznate commented Apr 2, 2013

This should probably be done before work starts on #162 (which should probably have this plumbing in place to make things easier). Thus, #161 is tangentially relevant as well.

@edwardcapriolo
Copy link
Collaborator Author

#161 and #162 both tangential. This feature should do one critical thing.

  1. ensure that any exception the handler throws is caught.

As a side effect it should/probably will make it easier to unit test the logic of a handler.

For a follow up we will be able to add yammer to this base class for performance tracking.

@edwardcapriolo
Copy link
Collaborator Author

So I coded up a simple base class called AbstractHandler. https://github.com/zznate/intravert-ug/tree/abstract_handler . Please supply some comments.

@zznate
Copy link
Owner

zznate commented Apr 9, 2013

This looks fine - I did something similar in for http - see o.u.v.handler.IntraHandlerBase.

I think we need to have better naming scheme for http vs. msg bus handlers and push that into the packages.

Having good/predictable package and class names will make it easy for people hacking around to get started.

@edwardcapriolo
Copy link
Collaborator Author

This is done. We can convert invidual handlers as we touch them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants