Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement XFBML.parse throughout the API #139

Open
simeyla opened this issue Aug 17, 2018 · 0 comments
Open

Implement XFBML.parse throughout the API #139

simeyla opened this issue Aug 17, 2018 · 0 comments

Comments

@simeyla
Copy link

simeyla commented Aug 17, 2018

XFBML.parse needs to run by itself, as necessary whenever a new component is added.

This should be extremely easy to do, just get the ElementRef in (probably) the ngOnViewInit handler and run XFBML.parse only on that node.

The current docs seem to encourage bad behavior by only suggesting the use of FB.init() at the component level. This will probably have performance impact.

Sorry to be mean but this is the most basic basic functionality that a package like this should have. I should be able to just add a <fb-like> wherever I want and only ever care about initializing the API at the root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant