Changing CustomDataParallel to DistributedDataParallel #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zylo117
reviewed
Aug 25, 2020
| def save_checkpoint(model, name): | ||
| if isinstance(model, CustomDataParallel): | ||
| if isinstance(model, torch.nn.parallel.DistributedDataParallel): | ||
| torch.save(model.module.model.state_dict(), os.path.join(opt.saved_path, name)) |
Owner
There was a problem hiding this comment.
I'm not sure if DDP's module is the real model like DP
Owner
There was a problem hiding this comment.
ASAIK, it's model.model.state_dict() for DDP like the ordinary model. Or both are ok?
Owner
|
Hi, thanks for your contribution. |
Author
|
It's a pleasure. You did a great job. Yes. I've tested in the afternoon, but I'm training a big model now. Tomorrow I will do more tests to see; this model is running on my machine (job). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the previous CustomDataParallel to DistributedDataParallel to improve the training speed.