Copy from subject metadata to SMS attrs (zooniverse#3130)

* Copy priority from subject metadata to SMS attr

* Hound

* Priority->Metadata. Needs migration for training_subject field and extreme optimization

* Raw SQL for single update query

* Even raw-er SQL, rails5 compatibility, nil check

* Newlines

* add ability to make more subjects

* use num_subjects evaluator to build subjects

* preserve decimal values if they are provided

subject selectors allow for decimal priority values so we should preserve them if provided

* remove stray focus spec

Author: zwolf

app/controllers/api/v1/subject_sets_controller.rb

@@ -105,7 +105,9 @@ def add_relation(resource, relation, value)
         [ resource.id, subject_id, rand ]
       end
 
-      SetMemberSubject.import IMPORT_COLUMNS, new_sms_values, validate: false
+      result = SetMemberSubject.import IMPORT_COLUMNS, new_sms_values, validate: false
+      SubjectMetadataWorker.perform_async(resource.id)
+      result
     else
       super
     end

app/workers/subject_metadata_worker.rb

@@ -0,0 +1,20 @@
+class SubjectMetadataWorker
+  include Sidekiq::Worker
+
+  def perform(subject_set_id)
+    update_sms_priority_sql = <<-SQL
+      UPDATE set_member_subjects
+      SET    priority = CAST(subjects.metadata->>'#priority' AS NUMERIC)
+      FROM   subjects
+      WHERE  subjects.id = set_member_subjects.subject_id
+      AND    subjects.metadata ? '#priority'
+      AND    set_member_subjects.subject_set_id = $1
+    SQL
+
+    ActiveRecord::Base.connection.exec_update(
+      update_sms_priority_sql,
+      "SQL",
+      [[nil, subject_set_id]]
+    )
+  end
+end

spec/controllers/api/v1/subject_sets_controller_spec.rb

@@ -154,6 +154,13 @@
         run_update_links
       end
 
+      it "should queue the SMS metadata worker" do
+        expect(SubjectMetadataWorker)
+          .to receive(:perform_async)
+          .with(kind_of(Numeric))
+        run_update_links
+      end
+
       it "should call the unfinish workflow worker" do
         resource.workflows.each do |workflow|
           expect(UnfinishWorkflowWorker).to receive(:perform_async).with(workflow.id)

spec/factories/subject_sets.rb

@@ -2,6 +2,7 @@
   factory :subject_set do
     transient do
       num_workflows 1
+      num_subjects 2
     end
 
     sequence(:display_name) { |n| "Subject Set #{n}" }
@@ -16,8 +17,8 @@
     end
 
     factory :subject_set_with_subjects do
-      after(:create) do |set|
-        2.times do |i|
+      after(:create) do |set, evaluator|
+        evaluator.num_subjects.times do |i|
           subject = create(:subject, project: set.project, uploader: set.project.owner)
           create(:set_member_subject, subject_set: set, subject: subject)
         end

spec/workers/subject_metadata_worker_spec.rb

@@ -0,0 +1,30 @@
+require "spec_helper"
+
+RSpec.describe SubjectMetadataWorker do
+  let(:user) { create :user }
+  let(:project) { create :project_with_workflow, owner: user }
+  let(:workflow) { project.workflows.first }
+  let(:subject_set) do
+    create(:subject_set_with_subjects, num_subjects: 3, project: project, workflows: [workflow])
+  end
+
+  subject(:worker) { SubjectMetadataWorker.new }
+
+  before do
+    subject_set.subjects[0].metadata['#priority'] = 1/3.0
+    subject_set.subjects[1].metadata['#priority'] = "2"
+    subject_set.subjects.map(&:save)
+  end
+
+  describe "#perform" do
+    it 'copies priority from metadata to SMS attribute' do
+      worker.perform(subject_set.id)
+      sms_one, sms_two, sms_three = SetMemberSubject.find(
+        subject_set.set_member_subject_ids
+      ).sort_by(&:id)
+      expect(sms_one.priority).to eq(1/3.0)
+      expect(sms_two.priority).to eq(2)
+      expect(sms_three.priority).to be_nil
+    end
+  end
+end