Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Follow user_settings.twenty_four_hour_time #1015

Open
chrisbobbe opened this issue Oct 21, 2024 · 2 comments
Open

ui: Follow user_settings.twenty_four_hour_time #1015

chrisbobbe opened this issue Oct 21, 2024 · 2 comments
Milestone

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Oct 21, 2024

When we show timestamps, for example on messages in the message list, we should format them according to the user's setting:

  • user_settings.twenty_four_hour_time true: "13:52"
  • user_settings.twenty_four_hour_time false: "1:52 PM"

See:

  • Help center doc
  • UserSettings.twentyFourHourTime in lib/api/model/initial_snapshot.dart
  • UserSettingsUpdateEvent in lib/api/model/events.dart

Milestoning as "Launch" because I believe we do this in zulip-mobile.

@c-o-d-e-y-o-d-a
Copy link

I would like to work on this issue if it has not been assigned to anyone else.

@chrisbobbe
Copy link
Collaborator Author

Please see the Zulip project's guide to claiming an issue: https://zulip.readthedocs.io/en/latest/contributing/contributing.html#in-other-zulip-repositories

In particular:

In your comment, describe what part of the code you’re modifying and how you plan to approach the problem, based on what you learned in steps 1–4 above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants