Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msglist: For bulk moves with PropagateMode.changeLater, don't renarrow if user was reading earlier messages #1008

Open
chrisbobbe opened this issue Oct 19, 2024 · 0 comments
Labels
a-msglist The message-list screen, except what's label:a-content
Milestone

Comments

@chrisbobbe
Copy link
Collaborator

When messages are moved out of the current narrow with PropagateMode.changeLater, we always follow the move by renarrowing MessageListPage. If the user is scrolled up to much earlier messages than the ones that were moved, the context change will be unhelpful and confusing.

To fix, we can guess which onscreen message the user is reading and only renarrow if that message was moved. We can't always guess correctly, and that's fine. (When more than one message is visible, the user's eyes could be on any of them.) But a simple algorithm would be to choose the first message that's at least partly shown in the viewport. If screen-reader software is active and a message is selected, that message is probably a better choice.

Marking post-launch because zulip-mobile doesn't do this.

@chrisbobbe chrisbobbe added the a-msglist The message-list screen, except what's label:a-content label Oct 19, 2024
@chrisbobbe chrisbobbe added this to the Post-launch milestone Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-msglist The message-list screen, except what's label:a-content
Projects
Status: No status
Development

No branches or pull requests

1 participant