l10n: Add localized loading labels and update tests

cybernova2 · cybernova2 · commit 03f9ba95ae2a · 2025-12-10T23:57:32.000+05:30
Add a localized 'loading' label in multiple widgets and apply it consistently across the UI. Update ARB files and regenerate localization outputs. Update widget tests to use the localized semantics label instead of hardcoded strings.
diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
@@ -1419,5 +1419,9 @@
   "zulipAppTitle": "Zulip",
   "@zulipAppTitle": {
     "description": "The name of Zulip. This should be either 'Zulip' or a transliteration."
-  }
+  },
+   "loading": "Loading…",
+    "@loading": {
+      "description": "Label shown for loading indicators"
+    }
 }
diff --git a/lib/generated/l10n/zulip_localizations.dart b/lib/generated/l10n/zulip_localizations.dart
@@ -2066,6 +2066,12 @@ abstract class ZulipLocalizations {
   /// In en, this message translates to:
   /// **'Zulip'**
   String get zulipAppTitle;
+
+  /// Label shown for loading indicators
+  ///
+  /// In en, this message translates to:
+  /// **'Loading…'**
+  String get loading;
 }
 
 class _ZulipLocalizationsDelegate
diff --git a/lib/generated/l10n/zulip_localizations_ar.dart b/lib/generated/l10n/zulip_localizations_ar.dart
@@ -1180,4 +1180,7 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
 
   @override
   String get zulipAppTitle => 'Zulip';
+
+  @override
+  String get loading => 'Loading…';
 }
diff --git a/lib/generated/l10n/zulip_localizations_de.dart b/lib/generated/l10n/zulip_localizations_de.dart
@@ -1206,4 +1206,7 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
 
   @override
   String get zulipAppTitle => 'Zulip';
+
+  @override
+  String get loading => 'Loading…';
 }
diff --git a/lib/generated/l10n/zulip_localizations_el.dart b/lib/generated/l10n/zulip_localizations_el.dart
@@ -1180,4 +1180,7 @@ class ZulipLocalizationsEl extends ZulipLocalizations {
 
   @override
   String get zulipAppTitle => 'Zulip';
+
+  @override
+  String get loading => 'Loading…';
 }
diff --git a/lib/generated/l10n/zulip_localizations_en.dart b/lib/generated/l10n/zulip_localizations_en.dart
@@ -1180,6 +1180,9 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
 
   @override
   String get zulipAppTitle => 'Zulip';
+
+  @override
+  String get loading => 'Loading…';
 }
 
 /// The translations for English, as used in the United Kingdom (`en_GB`).
diff --git a/lib/generated/l10n/zulip_localizations_es.dart b/lib/generated/l10n/zulip_localizations_es.dart
@@ -1180,4 +1180,7 @@ class ZulipLocalizationsEs extends ZulipLocalizations {
 
   @override
   String get zulipAppTitle => 'Zulip';
+
+  @override
+  String get loading => 'Loading…';
 }
diff --git a/lib/generated/l10n/zulip_localizations_fr.dart b/lib/generated/l10n/zulip_localizations_fr.dart
@@ -1196,4 +1196,7 @@ class ZulipLocalizationsFr extends ZulipLocalizations {
 
   @override
   String get zulipAppTitle => 'Zulip';
+
+  @override
+  String get loading => 'Loading…';
 }
diff --git a/lib/generated/l10n/zulip_localizations_he.dart b/lib/generated/l10n/zulip_localizations_he.dart
@@ -1180,4 +1180,7 @@ class ZulipLocalizationsHe extends ZulipLocalizations {
 
   @override
   String get zulipAppTitle => 'Zulip';
+
+  @override
+  String get loading => 'Loading…';
 }
diff --git a/lib/generated/l10n/zulip_localizations_hu.dart b/lib/generated/l10n/zulip_localizations_hu.dart
@@ -1180,4 +1180,7 @@ class ZulipLocalizationsHu extends ZulipLocalizations {
 
   @override
   String get zulipAppTitle => 'Zulip';
+
+  @override
+  String get loading => 'Loading…';
 }
diff --git a/lib/generated/l10n/zulip_localizations_it.dart b/lib/generated/l10n/zulip_localizations_it.dart
@@ -1200,4 +1200,7 @@ class ZulipLocalizationsIt extends ZulipLocalizations {
 
   @override
   String get zulipAppTitle => 'Zulip';
+
+  @override
+  String get loading => 'Loading…';
 }
diff --git a/lib/generated/l10n/zulip_localizations_ja.dart b/lib/generated/l10n/zulip_localizations_ja.dart
@@ -1154,4 +1154,7 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
 
   @override
   String get zulipAppTitle => 'Zulip';
+
+  @override
+  String get loading => 'Loading…';
 }
diff --git a/lib/generated/l10n/zulip_localizations_nb.dart b/lib/generated/l10n/zulip_localizations_nb.dart
@@ -1180,4 +1180,7 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
 
   @override
   String get zulipAppTitle => 'Zulip';
+
+  @override
+  String get loading => 'Loading…';
 }
diff --git a/lib/generated/l10n/zulip_localizations_pl.dart b/lib/generated/l10n/zulip_localizations_pl.dart
@@ -1199,4 +1199,7 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
 
   @override
   String get zulipAppTitle => 'Zulip';
+
+  @override
+  String get loading => 'Loading…';
 }
diff --git a/lib/generated/l10n/zulip_localizations_ru.dart b/lib/generated/l10n/zulip_localizations_ru.dart
@@ -1212,4 +1212,7 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
 
   @override
   String get zulipAppTitle => 'Zulip';
+
+  @override
+  String get loading => 'Loading…';
 }
diff --git a/lib/generated/l10n/zulip_localizations_sk.dart b/lib/generated/l10n/zulip_localizations_sk.dart
@@ -1182,4 +1182,7 @@ class ZulipLocalizationsSk extends ZulipLocalizations {
 
   @override
   String get zulipAppTitle => 'Zulip';
+
+  @override
+  String get loading => 'Loading…';
 }
diff --git a/lib/generated/l10n/zulip_localizations_sl.dart b/lib/generated/l10n/zulip_localizations_sl.dart
@@ -1221,4 +1221,7 @@ class ZulipLocalizationsSl extends ZulipLocalizations {
 
   @override
   String get zulipAppTitle => 'Zulip';
+
+  @override
+  String get loading => 'Loading…';
 }
diff --git a/lib/generated/l10n/zulip_localizations_uk.dart b/lib/generated/l10n/zulip_localizations_uk.dart
@@ -1201,4 +1201,7 @@ class ZulipLocalizationsUk extends ZulipLocalizations {
 
   @override
   String get zulipAppTitle => 'Zulip';
+
+  @override
+  String get loading => 'Loading…';
 }
diff --git a/lib/generated/l10n/zulip_localizations_zh.dart b/lib/generated/l10n/zulip_localizations_zh.dart
@@ -1180,6 +1180,9 @@ class ZulipLocalizationsZh extends ZulipLocalizations {
 
   @override
   String get zulipAppTitle => 'Zulip';
+
+  @override
+  String get loading => 'Loading…';
 }
 
 /// The translations for Chinese, as used in China, using the Han script (`zh_Hans_CN`).
diff --git a/lib/widgets/action_sheet.dart b/lib/widgets/action_sheet.dart
@@ -253,10 +253,10 @@ class BottomSheetEmptyContentPlaceholder extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     final designVariables = DesignVariables.of(context);
-
+    final loc = ZulipLocalizations.of(context);
     final child = loading
         ? Semantics(
-      label: 'Loading…',
+      label:loc.loading ,
       textDirection: Directionality.of(context),
       liveRegion: true,
       focusable: true,
diff --git a/lib/widgets/home.dart b/lib/widgets/home.dart
@@ -247,7 +247,7 @@ class _LoadingPlaceholderPageState extends State<_LoadingPlaceholderPage> {
           mainAxisSize: MainAxisSize.min,
           children: [
             Semantics(
-              label: 'Loading…',
+              label: zulipLocalizations.loading,
               textDirection: Directionality.of(context),
               liveRegion: true,
               child:const CircularProgressIndicator(),
diff --git a/lib/widgets/message_list.dart b/lib/widgets/message_list.dart
@@ -1034,13 +1034,10 @@ class _MessageListState extends State<MessageList> with PerAccountStoreAwareStat
         child: Padding(
           padding: const EdgeInsets.symmetric(vertical: 16.0),
           child: Semantics(
-            label: 'Loading more messages',
+            label: zulipLocalizations.loading,
             textDirection: Directionality.of(context),
             liveRegion: true,
-            child: const CircularProgressIndicator(),
-          ),
-        ),
-      );
+            child: const CircularProgressIndicator())));
     }
 
     if (model.items.isEmpty && model.haveNewest && model.haveOldest) {
@@ -1295,15 +1292,15 @@ class _MessageListLoadingMore extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
+    final loc = ZulipLocalizations.of(context);
     return Center(
       child: Padding(
         padding: EdgeInsets.symmetric(vertical: 16.0),
         child: Semantics(
           textDirection: Directionality.of(context),
-          label: 'Loading more messages',
+          label: loc.loading,
           liveRegion: true,
-          child: CircularProgressIndicator(),
-        ))); // TODO perhaps a different indicator
+          child: CircularProgressIndicator()))); // TODO perhaps a different indicator
   }
 }
 
diff --git a/lib/widgets/topic_list.dart b/lib/widgets/topic_list.dart
@@ -166,18 +166,16 @@ class _TopicListState extends State<_TopicList> with PerAccountStoreAwareStateMi
   @override
   Widget build(BuildContext context) {
     if (lastFetchedTopics == null) {
+      final loc = ZulipLocalizations.of(context);
+
       return Center(
         child: Padding(
           padding: const EdgeInsets.symmetric(vertical: 16.0),
           child: Semantics(
             textDirection: Directionality.of(context),
-            label: 'Loading…',    // plain string (not localized)
+            label: loc.loading,
             liveRegion: true,
-            child: CircularProgressIndicator(),
-          ),
-        ),
-      );
-    }
+            child: CircularProgressIndicator(),),),);}
 
     // TODO(design) handle the rare case when `lastFetchedTopics` is empty
 
diff --git a/test/widgets/home_test.dart b/test/widgets/home_test.dart
@@ -18,6 +18,7 @@ import 'package:zulip/widgets/page.dart';
 import 'package:zulip/widgets/profile.dart';
 import 'package:zulip/widgets/subscription_list.dart';
 import 'package:zulip/widgets/theme.dart';
+import 'package:zulip/generated/l10n/zulip_localizations.dart';
 
 import '../api/fake_api.dart';
 import '../example_data.dart' as eg;
@@ -398,14 +399,15 @@ void main () {
 
     testWidgets('smoke', (tester) async {
       final SemanticsHandle semanticsHandle = tester.ensureSemantics();
+      final loc = await ZulipLocalizations.delegate.load(const Locale('en'));
       try {
         addTearDown(testBinding.reset);
         testBinding.globalStore.loadPerAccountDuration = loadPerAccountDuration;
         await prepare(tester);
 
         // While loading, the loading page should be shown and have the semantics label.
         checkOnLoadingPage();
-        expect(find.bySemanticsLabel('Loading…'), findsOneWidget);
+        expect(find.bySemanticsLabel(loc.loading), findsOneWidget);
 
         await tester.pump(loadPerAccountDuration);
         checkOnHomePage(tester, expectedAccount: eg.selfAccount);
@@ -416,6 +418,7 @@ void main () {
 
     testWidgets('"Try another account" button appears after timeout', (tester) async {
       final SemanticsHandle semanticsHandle = tester.ensureSemantics();
+      final loc = await ZulipLocalizations.delegate.load(const Locale('en'));
       try {
         addTearDown(testBinding.reset);
         testBinding.globalStore.loadPerAccountDuration = loadPerAccountDuration;
@@ -425,7 +428,7 @@ void main () {
         check(find.text('Try another account').hitTestable()).findsNothing();
 
         // The loading semantics should already be present.
-        expect(find.bySemanticsLabel('Loading…'), findsOneWidget);
+        expect(find.bySemanticsLabel(loc.loading), findsOneWidget);
 
         await tester.pump(kTryAnotherAccountWaitPeriod);
         checkOnLoadingPage();
@@ -440,6 +443,7 @@ void main () {
 
     testWidgets('while loading, go back from ChooseAccountPage', (tester) async {
       final SemanticsHandle semanticsHandle = tester.ensureSemantics();
+      final loc = await ZulipLocalizations.delegate.load(const Locale('en'));
       try {
         testBinding.globalStore.loadPerAccountDuration = loadPerAccountDuration;
         await prepare(tester);
@@ -457,7 +461,7 @@ void main () {
         checkOnLoadingPage();
 
         // Semantics check: loading label present
-        expect(find.bySemanticsLabel('Loading…'), findsOneWidget);
+        expect(find.bySemanticsLabel(loc.loading), findsOneWidget);
 
         await tester.pump(loadPerAccountDuration);
         checkOnHomePage(tester, expectedAccount: eg.selfAccount);
@@ -468,6 +472,7 @@ void main () {
 
     testWidgets('while loading, choose a different account', (tester) async {
       final SemanticsHandle semanticsHandle = tester.ensureSemantics();
+      final loc = await ZulipLocalizations.delegate.load(const Locale('en'));
       try {
         testBinding.globalStore.loadPerAccountDuration = loadPerAccountDuration;
         await prepare(tester);
@@ -480,7 +485,7 @@ void main () {
         // While the second account is still loading, we should be on a loading page.
         await tester.pump(loadPerAccountDuration);
         checkOnLoadingPage();
-        expect(find.bySemanticsLabel('Loading…'), findsOneWidget);
+        expect(find.bySemanticsLabel(loc.loading), findsOneWidget);
 
         await tester.pump(loadPerAccountDuration);
         // The second load finished.
@@ -492,6 +497,7 @@ void main () {
 
     testWidgets('while loading, choosing an account disallows going back', (tester) async {
       final SemanticsHandle semanticsHandle = tester.ensureSemantics();
+      final loc = await ZulipLocalizations.delegate.load(const Locale('en'));
       try {
         testBinding.globalStore.loadPerAccountDuration = loadPerAccountDuration;
         await prepare(tester);
@@ -506,7 +512,7 @@ void main () {
             .isNotNull().isFirst.isTrue();
 
         // Semantics check: ensure loading label present and first route is our account route.
-        expect(find.bySemanticsLabel('Loading…'), findsOneWidget);
+        expect(find.bySemanticsLabel(loc.loading), findsOneWidget);
 
         await tester.pump(loadPerAccountDuration); // wait for loadPerAccount
         checkOnHomePage(tester, expectedAccount: eg.otherAccount);
@@ -517,6 +523,7 @@ void main () {
 
     testWidgets('while loading, go to nested levels of ChooseAccountPage', (tester) async {
       final SemanticsHandle semanticsHandle = tester.ensureSemantics();
+      final loc = await ZulipLocalizations.delegate.load(const Locale('en'));
       try {
         testBinding.globalStore.loadPerAccountDuration = loadPerAccountDuration;
         final thirdAccount = eg.account(user: eg.thirdUser);
@@ -538,7 +545,7 @@ void main () {
           ..accountId.equals(eg.otherAccount.id);
 
         // Semantics: loading label should appear during the account switch.
-        expect(find.bySemanticsLabel('Loading…'), findsOneWidget);
+        expect(find.bySemanticsLabel(loc.loading), findsOneWidget);
 
         await tester.pump(kTryAnotherAccountWaitPeriod);
 
diff --git a/test/widgets/message_list_test.dart b/test/widgets/message_list_test.dart
@@ -39,6 +39,7 @@ import 'package:zulip/widgets/channel_colors.dart';
 import 'package:zulip/widgets/theme.dart';
 import 'package:zulip/widgets/topic_list.dart';
 import 'package:zulip/widgets/user.dart';
+import 'package:zulip/generated/l10n/zulip_localizations.dart';
 
 import '../api/fake_api.dart';
 import '../example_data.dart' as eg;
@@ -841,8 +842,9 @@ void main() {
 
       // Semantics check: ensure loading semantics label is not present
       final SemanticsHandle semanticsHandle = tester.ensureSemantics();
+      final loc = await ZulipLocalizations.delegate.load(const Locale('en'));
       try {
-        expect(find.bySemanticsLabel('Loading more messages'), findsNothing);
+        expect(find.bySemanticsLabel(loc.loading), findsNothing);
       } finally {
         semanticsHandle.dispose();
       }
@@ -880,8 +882,8 @@ void main() {
       check(tester.getRect(find.text('message 9')))
         .bottom.isGreaterThan(loadingIndicatorRect.top - 36); // TODO(#1569) where's this space going?
         //Semantics check: ensure the loading indicator exposes the expected label
-        expect(find.bySemanticsLabel('Loading more messages'), findsOneWidget);
-
+        final loc = await ZulipLocalizations.delegate.load(const Locale('en'));
+        expect(find.bySemanticsLabel(loc.loading), findsOneWidget);
         await tester.pumpAndSettle();
       } finally {
         semanticsHandle.dispose();
diff --git a/test/widgets/topic_list_test.dart b/test/widgets/topic_list_test.dart

Original file line number	Diff line number	Diff line change
`@@ -1180,4 +1180,7 @@ class ZulipLocalizationsAr extends ZulipLocalizations {`
`1180`	`1180`
`1181`	`1181`	`@override`
`1182`	`1182`	`String get zulipAppTitle => 'Zulip';`
	`1183`	`+`
	`1184`	`+ @override`
	`1185`	`+ String get loading => 'Loading…';`
`1183`	`1186`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1206,4 +1206,7 @@ class ZulipLocalizationsDe extends ZulipLocalizations {`
`1206`	`1206`
`1207`	`1207`	`@override`
`1208`	`1208`	`String get zulipAppTitle => 'Zulip';`
	`1209`	`+`
	`1210`	`+ @override`
	`1211`	`+ String get loading => 'Loading…';`
`1209`	`1212`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1180,6 +1180,9 @@ class ZulipLocalizationsEn extends ZulipLocalizations {`
`1180`	`1180`
`1181`	`1181`	`@override`
`1182`	`1182`	`String get zulipAppTitle => 'Zulip';`
	`1183`	`+`
	`1184`	`+ @override`
	`1185`	`+ String get loading => 'Loading…';`
`1183`	`1186`	`}`
`1184`	`1187`
`1185`	`1188`	/// The translations for English, as used in the United Kingdom (`en_GB`).
Original file line number	Diff line number	Diff line change
`@@ -1196,4 +1196,7 @@ class ZulipLocalizationsFr extends ZulipLocalizations {`
`1196`	`1196`
`1197`	`1197`	`@override`
`1198`	`1198`	`String get zulipAppTitle => 'Zulip';`
	`1199`	`+`
	`1200`	`+ @override`
	`1201`	`+ String get loading => 'Loading…';`
`1199`	`1202`	`}`