Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Releases do not include url.h/url.h source #36

Open
jedahan opened this issue Mar 9, 2017 · 3 comments
Open

Releases do not include url.h/url.h source #36

jedahan opened this issue Mar 9, 2017 · 3 comments
Assignees
@desyncr
Labels
bug
Milestone
v0.1.1

Comments

@jedahan
Copy link

jedahan commented Mar 9, 2017

For #35 , it would be nice if the release tar.gz and .zip would include the submodule source.
@desyncr desyncr added the bug label Mar 9, 2017
@desyncr desyncr added this to the v0.1.1 milestone Mar 9, 2017
@desyncr
Copy link
Member

desyncr commented Mar 9, 2017

Interesting, I haven't seen it was missing the url.h module on the downloads. I guess I'll have to generate .tar.gz and .zip on the release.

@desyncr
Copy link
Member

desyncr commented Mar 9, 2017

Here is how I create release packages for Antigen, it could serve as a reference.

@desyncr desyncr self-assigned this Mar 9, 2017
@jedahan
Copy link
Author

jedahan commented Mar 9, 2017

I was able to work around this in the homebrew formula, which works fine:

https://github.com/Homebrew/homebrew-core/pull/10818/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@desyncr desyncr

Labels
bug
Projects
None yet
Milestone
v0.1.1
Development

No branches or pull requests
2 participants
@jedahan @desyncr