Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review multi-host support #3

Closed
2 tasks done
desyncr opened this issue Feb 2, 2017 · 2 comments
Closed
2 tasks done

Review multi-host support #3

desyncr opened this issue Feb 2, 2017 · 2 comments
Assignees
Milestone

Comments

@desyncr
Copy link
Member

desyncr commented Feb 2, 2017

  • Review implementation to be fully host agnostic (github, bitbucket, etc)
  • Avoid hardcoding hosts (try to...)
  • Add tests

@fennecdjay I have yet no idea how to implement this so any suggestion is welcome!

We should discuss here before doing any PR :)

TODO

  • Using "https://" causes plugin install to fail
  • It does creates "<hostname>/user/repo.git" folders
@desyncr desyncr added this to the v0.1.0 milestone Feb 2, 2017
@desyncr desyncr self-assigned this Feb 3, 2017
@fennecdjay
Copy link
Member

fennecdjay commented Feb 4, 2017

Maybe we could have

#define ZPM_DEFAULT_HOST "github.com"

in config.h then

if (!(host = getenv(ZPM_DEFAULT_HOST)) {
    host = ZPM_DEFAULT_VALUE;
}

I can give it a try tomorrow if you want.

@desyncr
Copy link
Member Author

desyncr commented Feb 14, 2017

Done in #28

@desyncr desyncr closed this as completed Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants