Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeleteJobsCommon Function does not return API response for ModifyVersion 2.0 when parameter not passed #2354

Open
awharn opened this issue Nov 7, 2024 · 1 comment
Open

DeleteJobsCommon Function does not return API response for ModifyVersion 2.0 when parameter not passed #2354

awharn opened this issue Nov 7, 2024 · 1 comment
Labels
bug Something isn't working needs-ported Indicates that a PR needs to be ported (master - lts-incremental) priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.

Comments

@awharn
Copy link
Member

awharn commented Nov 7, 2024

Describe the bug

DeleteJobsCommon checks for modifyVersion to be 1.0 to attach the Version 1 header. Otherwise it attaches the Version 2 header. However, later logic explicitly checks if modifyVersion is 2.0 and if it is, it will return the response from the API, otherwise it will not. This means that if modifyVersion is not passed, it will default to 2.0 but will not return the API response to the calling function. This was fixed as part of #2352 but was not ported to V2. Respective files are DeleteJobs.ts, DeleteJobs.unit.test.ts, and DeleteJobs.system.test.ts.

Expected and actual results

Describe your environment

Additional context
@awharn awharn added bug Something isn't working needs-ported Indicates that a PR needs to be ported (master - lts-incremental) new The issue wasn't triaged yet labels Nov 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@awharn awharn changed the title DeleteJobsCommon Function does not return for ModifyVersion 2.0 when parameter not passed DeleteJobsCommon Function does not return API response for ModifyVersion 2.0 when parameter not passed Nov 7, 2024
@JTonda JTonda added priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex. and removed new The issue wasn't triaged yet labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs-ported Indicates that a PR needs to be ported (master - lts-incremental) priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.
Projects
Zowe CLI Squad
Status: Medium Priority
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JTonda @awharn