Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing progress bar on zos-files upload dir-to-uss command #2344

Open
t1m0thyj opened this issue Nov 1, 2024 · 2 comments
Open

Fix missing progress bar on zos-files upload dir-to-uss command #2344

t1m0thyj opened this issue Nov 1, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers priority-low Legit issue but cosmetic or nice-to-have severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases

Comments

@t1m0thyj
Copy link
Member

t1m0thyj commented Nov 1, 2024

The command handler creates a progress task but never calls the startBar and endBar methods:
https://github.com/zowe/zowe-cli/blob/master/packages/cli/src/zosfiles/upload/dtu/DirToUSSDir.handler.ts

We should surround the following lines with calls to the commandParameters.response.progress API:

const uploadApi = commandParameters.arguments.recursive ? Upload.dirToUSSDirRecursive : Upload.dirToUSSDir;
const response = await uploadApi.bind(Upload)(session, inputDir, commandParameters.arguments.USSDir, uploadOptions);

@t1m0thyj t1m0thyj added bug Something isn't working good first issue Good for newcomers new The issue wasn't triaged yet labels Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@t1m0thyj
Copy link
Member Author

t1m0thyj commented Nov 1, 2024

Related to #1543

@JTonda JTonda added priority-low Legit issue but cosmetic or nice-to-have severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases and removed new The issue wasn't triaged yet labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers priority-low Legit issue but cosmetic or nice-to-have severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases
Projects
Status: Low Priority
Development

No branches or pull requests

2 participants