Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite daemon implementation for Windows to stop using named_pipe #1465

Closed
t1m0thyj opened this issue Jul 1, 2022 · 4 comments · Fixed by #1710
Closed

Rewrite daemon implementation for Windows to stop using named_pipe #1465

t1m0thyj opened this issue Jul 1, 2022 · 4 comments · Fixed by #1710
Labels
daemon-mode enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have

Comments

@t1m0thyj
Copy link
Member

t1m0thyj commented Jul 1, 2022

The named_pipe crate has not been updated for a few years and is no longer maintained (see blackbeam/named_pipe#13 (comment)).

The recommended replacement seems to be Tokio:
https://docs.rs/tokio/latest/tokio/net/windows/named_pipe/index.html

@dkelosky
Copy link
Contributor

it would be cool to reintroduce (via extra controls) the ability to allow tcp sockets for the daemon (like dockerd). i used to be able to share my daemon with my windows and ubuntu wsl instance. it's not really noticeable, but tcp when measured appears to be slightly more performant.

for non-multi user systems and bound to localhost, i would much prefer to use tcp 😄

@Trisk3lion
Copy link

Thumbs up from me for @dkelosky suggestion.

It may also solve issue #1318, because it worked fine with that solution.

@t1m0thyj t1m0thyj added enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have labels Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Thank you for raising this issue.
The community has 90 days to upvote 👍 the issue.
If it receives 5 upvotes, we will move it to our backlog. If not, we will close it.

@zFernand0 zFernand0 added enhancement New feature or request and removed enhancement New feature or request labels Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Thank you for raising this enhancement request.
The community has 90 days to vote on it.
If the enhancement receives at least 5 upvotes, it is added to our development backlog.
If it receives fewer votes, the issue is closed.

@traeok traeok linked a pull request May 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
daemon-mode enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants