Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YourStats story is broken in Safari #6324

Open
1 of 6 tasks
eatyourgreens opened this issue Sep 19, 2024 · 2 comments
Open
1 of 6 tasks

YourStats story is broken in Safari #6324

eatyourgreens opened this issue Sep 19, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@eatyourgreens
Copy link
Contributor

eatyourgreens commented Sep 19, 2024

Package

Choose from the list:

  • app-content-pages
  • app-project
  • lib-classifier
  • lib-panoptes-js
  • lib-react-components
  • unknown

Describe the bug

YourStats should show a bar chart for seven weekdays, but it's only showing two days in Safari. All seven days are present in the DOM inspector, but all are labelled with 'Invalid Date', except Monday.

Screenshot of the YourStats bar chart in Safari, showing two bars, not seven.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://zooniverse.github.io/front-end-monorepo/@zooniverse/fe-project/index.html?path=/story/project-app-screens-classify-your-stats--your-stats#storybook-preview-wrapper in Safari.
  2. Navigate the bar chart with VoiceOver and you'll hear 'Invalid Date: 0' for all the missing days.

Expected behavior

The chart should have seven days, each labelled with name of the day in your locale.

Additional context

I think this might have broken when stats moved over to the new stats API. Maybe the mocks for this story weren't updated?

@eatyourgreens eatyourgreens added the bug Something isn't working label Sep 19, 2024
@eatyourgreens eatyourgreens changed the title YourStats story is broken in the storybook YourStats story is broken in Safari Sep 19, 2024
@eatyourgreens
Copy link
Contributor Author

In Firefox, there are only 6 days, and they are shown in reverse order (Saturday on the left, Monday on the right.)

Your Stats in Firefox, showing 6 days, labelled: S F T W T M.

@eatyourgreens
Copy link
Contributor Author

The chart looks fine on live projects, so I think the problem might be the mock data used by the stories and tests.

A bar chart of personal daily classifications for Gravity Spy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant