Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to minified js in app, but make sure they don't break testing #62

Open
jstirnaman opened this issue Apr 7, 2015 · 1 comment

Comments

@jstirnaman
Copy link
Contributor

In develop branch, minified JS does not work with testing framework without a workaround. Add a workaround and switch the app back to minified.

@jstirnaman jstirnaman self-assigned this Apr 7, 2015
@jstirnaman
Copy link
Contributor Author

It looks like the pattern for supporting minification is generally to use the expanded signature for modules. e.g.
//Controllers
var myController = function(anyVariableName, $http) {}
myController.$inject = ['$scope', '$http']

//Modules
var myModule = angular.module('myModule', [ //Dependencies go here as an array of strings.])

//Services
myModule.service('serviceName', ['$http', '$location', function($http, $location) {}])

@zmon zmon removed the help wanted label Feb 29, 2016
@jstirnaman jstirnaman removed their assignment May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants